Skip to content

⚡ Bolt: Eliminate O(N) server lookups in Lua API - #285

Closed
mleem97 wants to merge 1 commit into
mainfrom
bolt/optimize-lua-server-module-12245892006353904028
Closed

mleem97 wants to merge 1 commit into
mainfrom
bolt/optimize-lua-server-module-12245892006353904028

Conversation

@mleem97

@mleem97 mleem97 commented Sep 22, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>() with O(1) dictionary iterations from Il2Cpp.NetworkMap.instance dictionaries in LuaServerModule.cs (get_all, repair, repair_all). Added defensive copying in repair_all to safely mutate the collection, and fallback to FindObjectsOfType for uninitialized network map scenarios.
🎯 Why: FindObjectsOfType scans the entire Unity scene hierarchy. When called frequently by Lua scripts, it causes severe CPU blocking and triggers heavy IL2CPP GC pressure due to array allocation.
📊 Impact: Transforms O(N) scene-wide object queries into O(1) direct dictionary enumerations, heavily reducing per-frame CPU latency and heap allocations for script-heavy environments.
🔬 Measurement: Execution time of greg.server.get_all() via Lua profiling will drop significantly as device count scales.


PR created automatically by Jules for task 12245892006353904028 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 16 complexity · 2 duplication

Metric Results
Complexity 16
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

This was referenced Sep 22, 2026
@mleem97

mleem97 commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

Applied locally / triaged; closing bot-PR backlog. GitHub is a mirror — active development happens on Forgejo/Gitea.

@mleem97 mleem97 closed this Sep 22, 2026
@mleem97
mleem97 deleted the bolt/optimize-lua-server-module-12245892006353904028 branch September 22, 2026 11:12
@google-labs-jules

Copy link
Copy Markdown

Applied locally / triaged; closing bot-PR backlog. GitHub is a mirror — active development happens on Forgejo/Gitea.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant