Skip to content

⚡ Bolt: Optimize Expensive Hardware Queries via NetworkMap - #275

Closed
mleem97 wants to merge 1 commit into
mainfrom
jules-16944944298658470618-fc0a9077
Closed

mleem97 wants to merge 1 commit into
mainfrom
jules-16944944298658470618-fc0a9077

Conversation

@mleem97

@mleem97 mleem97 commented Sep 15, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced costly O(N) FindObjectsOfTypeAll queries in GameAPI.cs and LuaServerModule.cs with O(1) dictionary lookups via NetworkMap.instance. Throttled a UI check polling FindObjectsOfType in greg.QoL/Main.cs.
🎯 Why: FindObjectsOfTypeAll scans the entire scene hierarchy, severely impacting performance and increasing GC pressure when called frequently.
📊 Impact: Expected to reduce CPU time significantly during object lookups, especially as the number of devices scales up. Prevents massive hitches in API heavy scenarios.
🔬 Measurement: Verify via test suite. Observe decreased CPU utilization overhead from the API and Mod Loader.


PR created automatically by Jules for task 16944944298658470618 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 2 high · 3 medium

Alerts:
⚠ 5 issues (≤ 0 issues of at least minor severity)

Results:
5 new issues

Category Results
UnusedCode 1 medium
Security 2 high
Complexity 2 medium

View in Codacy

🟢 Metrics 18 complexity · 8 duplication

Metric Results
Complexity 18
Duplication 8

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mleem97

mleem97 commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #285 (newer iteration of the same bot-generated NetworkMap optimization; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea.

@mleem97 mleem97 closed this Sep 22, 2026
@mleem97
mleem97 deleted the jules-16944944298658470618-fc0a9077 branch September 22, 2026 10:57
@google-labs-jules

Copy link
Copy Markdown

Superseded by #285 (newer iteration of the same bot-generated NetworkMap optimization; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant