Skip to content

⚡ Bolt: Optimize FindObjectsOfType with NetworkMap lookups - #278

Closed
mleem97 wants to merge 1 commit into
mainfrom
bolt-optimize-hardware-lookups-1592600162861850342
Closed

mleem97 wants to merge 1 commit into
mainfrom
bolt-optimize-hardware-lookups-1592600162861850342

Conversation

@mleem97

@mleem97 mleem97 commented Sep 17, 2026

Copy link
Copy Markdown
Owner
  • 💡 What: Replaced O(N) UnityEngine.Object.FindObjectsOfType<T> scene queries with O(1) dictionary lookups from NetworkMap.instance (servers, switches, patchPanels).
  • 🎯 Why: FindObjectsOfType is extremely expensive as it scans the entire object hierarchy. This optimization drastically reduces CPU overhead and GC pressure during world syncs and hardware retrievals, especially in large data centers.
  • 📊 Impact: O(1) lookups instead of O(N). Improves overall responsiveness and reduces hitching.
  • 🔬 Measurement: Observe CPU load and framerates during world synchronization or API calls. Monitor reduced time spent in FindObjectsOfType via profilers.

PR created automatically by Jules for task 1592600162861850342 started by @mleem97

Replaced O(N) scene queries with O(1) dictionary lookups from NetworkMap.instance for servers, switches, and patch panels.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 13 complexity · 0 duplication

Metric Results
Complexity 13
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mleem97

mleem97 commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #285 (newer iteration of the same bot-generated NetworkMap optimization; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea.

@mleem97 mleem97 closed this Sep 22, 2026
@mleem97
mleem97 deleted the bolt-optimize-hardware-lookups-1592600162861850342 branch September 22, 2026 10:57
@google-labs-jules

Copy link
Copy Markdown

Superseded by #285 (newer iteration of the same bot-generated NetworkMap optimization; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea.

Understood. Acknowledging that this work is superseded and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant