Repository navigation
Conversation
- Replaced O(N) scene scans using `FindObjectsOfType<Il2Cpp.Server>()` with O(1) dictionary lookups via `Il2Cpp.NetworkMap.instance.servers` and `brokenServers` in `LuaServerModule.cs`. - Retained fallback logic for uninitialized game states. - Avoids large garbage collection spikes when querying server data or repairing all servers via Lua scripting.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Replaced O(N) scene scans using `FindObjectsOfType<Il2Cpp.Server>()` with O(1) dictionary lookups via `Il2Cpp.NetworkMap.instance.servers` and `brokenServers` in `LuaServerModule.cs`. - Retained fallback logic for uninitialized game states. - Avoids large garbage collection spikes when querying server data or repairing all servers via Lua scripting.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 7 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
Superseded by #285 (newer iteration of the same bot-generated NetworkMap optimization; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
💡 What: Replaced
UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>()with O(1) accesses throughIl2Cpp.NetworkMap.instance.serversandIl2Cpp.NetworkMap.instance.brokenServersinsideLuaServerModule.csforgreg.server.get_all()andgreg.server.repair_all().🎯 Why:
FindObjectsOfTypescans the entire scene object hierarchy. In larger data centers, calling these Lua API functions causes severe hitches and GC pressure due to the O(N) allocation of object arrays.📊 Impact: Reduces CPU time and GC overhead in Lua-heavy setups. Querying all servers or repairing all servers now avoids allocating massive object arrays when the
NetworkMapis initialized.🔬 Measurement: Run a large data center save, execute
greg.server.get_all()orgreg.server.repair_all()via Lua console, and observe significantly lower frame times during execution.PR created automatically by Jules for task 1644735588486460584 started by @mleem97