Skip to content

⚡ Bolt: Optimize server lookups in Lua API - #237

Closed
mleem97 wants to merge 1 commit into
mainfrom
bolt/optimize-lua-server-findobjects-11186725718716675700
Closed

mleem97 wants to merge 1 commit into
mainfrom
bolt/optimize-lua-server-findobjects-11186725718716675700

Conversation

@mleem97

@mleem97 mleem97 commented Aug 15, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced O(N) FindObjectsOfType<Il2Cpp.Server> calls with O(1) lookups via Il2Cpp.NetworkMap.instance.servers in LuaServerModule.

🎯 Why: Calling FindObjectsOfType scans the entire Unity scene hierarchy and causes massive CPU overhead and garbage collection pressure, particularly when invoked from Lua scripts tracking large data centers.

📊 Impact: Dramatically reduces CPU overhead and hitching when executing Lua API calls like server.get_all() or server.repair_all() in late-game saves.

🔬 Measurement: Monitor frame time (Profiler) during intensive Lua operations and observe reduced CPU time in FindObjectsOfType allocations.


PR created automatically by Jules for task 11186725718716675700 started by @mleem97

Replaced O(N) `FindObjectsOfType<Il2Cpp.Server>` calls with O(1) lookups via `Il2Cpp.NetworkMap.instance.servers` in `LuaServerModule`.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 3 high

Alerts:
⚠ 3 issues (≤ 0 issues of at least minor severity)

Results:
3 new issues

Category Results
Security 3 high

View in Codacy

🟢 Metrics 5 complexity · 12 duplication

Metric Results
Complexity 5
Duplication 12

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mleem97

mleem97 commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #285 (newer iteration of the same bot-generated NetworkMap optimization; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea.

@mleem97 mleem97 closed this Sep 22, 2026
@mleem97
mleem97 deleted the bolt/optimize-lua-server-findobjects-11186725718716675700 branch September 22, 2026 10:58
@google-labs-jules

Copy link
Copy Markdown

Superseded by #285 (newer iteration of the same bot-generated NetworkMap optimization; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant