Skip to content

⚡ Bolt: Optimize LuaServerModule server retrieval with NetworkMap O(1) lookups - #253

Closed
mleem97 wants to merge 1 commit into
mainfrom
bolt-lua-server-optimizations-5497010197911612809
Closed

mleem97 wants to merge 1 commit into
mainfrom
bolt-lua-server-optimizations-5497010197911612809

Conversation

@mleem97

@mleem97 mleem97 commented Aug 25, 2026

Copy link
Copy Markdown
Owner

💡 What: Refactored greg.server.get_all() and greg.server.repair() in LuaServerModule.cs to use the O(1) Il2Cpp.NetworkMap.instance.servers and brokenServers dictionaries directly, replacing the O(N) UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>() method.
🎯 Why: Calling FindObjectsOfType is an extremely expensive O(N) scene query that creates unnecessary GC pressure and CPU overhead. The Lua API methods frequently query servers which causes hitches in large data centers.
📊 Impact: Significantly reduces CPU overhead and GC allocations when executing Lua scripts interacting with servers. Changes a blocking O(N) scene query to a fast O(1) dictionary lookup.
🔬 Measurement: Run the test suite using export DOTNET_ROLL_FORWARD=Major; dotnet test tests/gregCore.Tests.csproj to confirm no regressions. In game, the frame hitch when invoking Lua server functions will be eliminated.


PR created automatically by Jules for task 5497010197911612809 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mleem97

mleem97 commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #285 (newer iteration of the same bot-generated NetworkMap optimization; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea.

@mleem97 mleem97 closed this Sep 22, 2026
@mleem97
mleem97 deleted the bolt-lua-server-optimizations-5497010197911612809 branch September 22, 2026 10:58
@google-labs-jules

Copy link
Copy Markdown

Superseded by #285 (newer iteration of the same bot-generated NetworkMap optimization; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant