Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in greg.io.list_files - #284

Closed
mleem97 wants to merge 1 commit into
mainfrom
sentinel-lua-path-traversal-9864405536772394499
Closed

mleem97 wants to merge 1 commit into
mainfrom
sentinel-lua-path-traversal-9864405536772394499

Conversation

@mleem97

@mleem97 mleem97 commented Sep 22, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The Directory.GetFiles call in greg.io.list_files within GregIoLuaModule.cs directly accepted user-provided pattern input without validating it for path traversal sequences like ../. This allowed malicious Lua scripts to escape the sandbox (dataDir) and enumerate files anywhere on the file system that the process had access to.
🎯 Impact: Malicious actors could discover and enumerate the presence and structure of sensitive files and directories on the host server or player's machine, outside the intended Mod directory scope.
πŸ”§ Fix: Added explicit validation to the pattern argument to throw an UnauthorizedAccessException if it contains .., Path.DirectorySeparatorChar, or Path.AltDirectorySeparatorChar.
βœ… Verification: Verified compilation and no regressions via dotnet test using DOTNET_ROLL_FORWARD=Major. Verified .jules/sentinel.md journal is properly updated.


PR created automatically by Jules for task 9864405536772394499 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Up to standards βœ…

🟒 Issues 0 issues

Results:
0 new issues

View in Codacy

🟒 Metrics 4 complexity · 0 duplication

Metric Results
Complexity 4
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mleem97

mleem97 commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

Applied locally / triaged; closing bot-PR backlog. GitHub is a mirror β€” active development happens on Forgejo/Gitea.

@mleem97 mleem97 closed this Sep 22, 2026
@mleem97
mleem97 deleted the sentinel-lua-path-traversal-9864405536772394499 branch September 22, 2026 11:12
@google-labs-jules

Copy link
Copy Markdown

Applied locally / triaged; closing bot-PR backlog. GitHub is a mirror β€” active development happens on Forgejo/Gitea.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant