Repository navigation
Conversation
…l vulnerability in the Lua directory listing functionality.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Up to standards ✅🟢 Issues
|
…isting functionality.
|
Superseded by #284 (newer iteration of the same bot-generated fix; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
🚨 Severity: HIGH
💡 Vulnerability: The
list_filesfunction in the Lua IO module (GregIoLuaModule) accepted an unsanitizedpatternstring, which was passed directly as thesearchPatternargument toDirectory.GetFiles. This allowed path traversal using..and directory separators.🎯 Impact: An attacker or malicious mod could escape the sandbox data directory and enumerate arbitrary files and directories on the system.
🔧 Fix: Added validation to the
patternargument to throw anUnauthorizedAccessExceptionif it contains..,Path.DirectorySeparatorChar, orPath.AltDirectorySeparatorChar.✅ Verification: Ensured the codebase compiles successfully.
PR created automatically by Jules for task 3724543601817907772 started by @mleem97