Skip to content

🛡️ Sentinel: [HIGH] Fix path traversal in Lua list_files - #283

Closed
mleem97 wants to merge 2 commits into
mainfrom
sentinel/fix-list-files-traversal-3724543601817907772
Closed

mleem97 wants to merge 2 commits into
mainfrom
sentinel/fix-list-files-traversal-3724543601817907772

Conversation

@mleem97

@mleem97 mleem97 commented Sep 20, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
💡 Vulnerability: The list_files function in the Lua IO module (GregIoLuaModule) accepted an unsanitized pattern string, which was passed directly as the searchPattern argument to Directory.GetFiles. This allowed path traversal using .. and directory separators.
🎯 Impact: An attacker or malicious mod could escape the sandbox data directory and enumerate arbitrary files and directories on the system.
🔧 Fix: Added validation to the pattern argument to throw an UnauthorizedAccessException if it contains .., Path.DirectorySeparatorChar, or Path.AltDirectorySeparatorChar.
✅ Verification: Ensured the codebase compiles successfully.


PR created automatically by Jules for task 3724543601817907772 started by @mleem97

…l vulnerability in the Lua directory listing functionality.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

codacy-production Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mleem97

mleem97 commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #284 (newer iteration of the same bot-generated fix; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea.

@mleem97 mleem97 closed this Sep 22, 2026
@mleem97
mleem97 deleted the sentinel/fix-list-files-traversal-3724543601817907772 branch September 22, 2026 10:56
@google-labs-jules

Copy link
Copy Markdown

Superseded by #284 (newer iteration of the same bot-generated fix; closing duplicates). GitHub is a mirror — active development happens on Forgejo/Gitea.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant