Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Lua io.list_files pattern - #274

Closed
mleem97 wants to merge 1 commit into
mainfrom
sentinel/fix-lua-list-files-traversal-4421909771687818448
Closed

mleem97 wants to merge 1 commit into
mainfrom
sentinel/fix-lua-list-files-traversal-4421909771687818448

Conversation

@mleem97

@mleem97 mleem97 commented Sep 15, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The greg.io.list_files Lua function passed user-supplied search patterns directly to Directory.GetFiles. This allowed directory traversal attacks (e.g., using a pattern like ../secret/*.*) to escape the restricted data folder sandbox.
🎯 Impact: Malicious mod scripts could potentially read files arbitrarily across the filesystem, completely bypassing the intended I/O sandboxing.
πŸ”§ Fix: Added a validation step before invoking Directory.GetFiles to ensure the pattern does not contain .. or directory separator characters, correctly isolating the mod to its data directory.
βœ… Verification: Ran the .NET test suite and explicitly verified via temporary scratchpads that search patterns with ../ will be successfully blocked by the new condition.


PR created automatically by Jules for task 4421909771687818448 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Up to standards βœ…

🟒 Issues 0 issues

Results:
0 new issues

View in Codacy

🟒 Metrics 4 complexity · 0 duplication

Metric Results
Complexity 4
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mleem97

mleem97 commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #284 (newer iteration of the same bot-generated fix; closing duplicates). GitHub is a mirror β€” active development happens on Forgejo/Gitea.

@mleem97 mleem97 closed this Sep 22, 2026
@mleem97
mleem97 deleted the sentinel/fix-lua-list-files-traversal-4421909771687818448 branch September 22, 2026 10:56
@google-labs-jules

Copy link
Copy Markdown

Superseded by #284 (newer iteration of the same bot-generated fix; closing duplicates). GitHub is a mirror β€” active development happens on Forgejo/Gitea.

Understood. Acknowledging that this PR has been superseded and is obsolete, stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant