Add allowWatchBookmarks and resourceVersionMatch support to GenericKubernetesApi list/watch - #4892
Closed
brendandburns with Copilot wants to merge 8 commits into
Closed
Add allowWatchBookmarks and resourceVersionMatch support to GenericKubernetesApi list/watch#4892brendandburns with Copilot wants to merge 8 commits into
allowWatchBookmarks and resourceVersionMatch support to GenericKubernetesApi list/watch#4892brendandburns with Copilot wants to merge 8 commits into
Conversation
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
|
Copilot
AI
changed the title
Add GenericKubernetesApi support for allowWatchBookmarks and resourceVersionMatch
Add Sep 1, 2026
allowWatchBookmarks and resourceVersionMatch support to GenericKubernetesApi list/watch
Copilot created this pull request from a session on behalf of
brendandburns
September 1, 2026 16:13
View session
brendandburns
approved these changes
Sep 1, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, Copilot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
brendandburns
marked this pull request as ready for review
September 1, 2026 16:15
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change closes a concrete parity gap with client-go in the Java dynamic/generic client path: list/watch calls could not express
allowWatchBookmarksandresourceVersionMatch. As a result, consumers could not request bookmark events or control resourceVersion matching semantics throughListOptions.API surface:
ListOptionsparityallowWatchBookmarksandresourceVersionMatchfields toListOptionsRequest wiring:
GenericKubernetesApiCustomObjectsApiCoverage updates
GenericKubernetesApiTestto assert query parameter propagation for list and watchDynamicApiTestusingDynamicKubernetesApiwith real list filtering + resourceVersion semantics