Skip to content

Add ListOptions watch parity and fluent builder - #4893

Open
brendandburns wants to merge 1 commit into
kubernetes-client:masterfrom
brendandburns:fix-genericapi-listoptions-watch-parity
Open

Add ListOptions watch parity and fluent builder#4893
brendandburns wants to merge 1 commit into
kubernetes-client:masterfrom
brendandburns:fix-genericapi-listoptions-watch-parity

Conversation

@brendandburns

Copy link
Copy Markdown
Contributor

Splits the generic ListOptions changes out of #4892.

Summary

  • add watch-related parity fields to ListOptions and GenericKubernetesApi
  • add a fluent ListOptions builder
  • return an independent copy from build() so later builder mutations do not affect previously built options
  • add unit and end-to-end coverage

Validation

  • ./mvnw -q -pl util,e2e -am compile test-compile -DskipTests

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from yue9944882 September 1, 2026 19:10
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 1, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: brendandburns / name: Brendan Burns (b1bb36f)

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 1, 2026
Add watch-related ListOptions fields, GenericKubernetesApi forwarding, and a fluent builder that returns independent option instances.
@brendandburns
brendandburns force-pushed the fix-genericapi-listoptions-watch-parity branch from 48e59bd to b1bb36f Compare September 1, 2026 19:19
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant