Add predicate-aware informer event handlers - #4894
Open
brendandburns wants to merge 1 commit into
Open
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
|
|
kubernetes-prow
Bot
added
cncf-cla: no
brendandburns
force-pushed
the
fix-predicate-informer-event-handlers
branch
from
September 1, 2026 19:19
f95f16d to
ea2cb84
Compare
kubernetes-prow
Bot
added
cncf-cla: yes
brendandburns
commented
Sep 1, 2026
| try { | ||
| return filter.test(obj); | ||
| } catch (RuntimeException e) { | ||
| return false; |
Contributor
Author
There was a problem hiding this comment.
Add a log here so that we don't silently drop events.
Add predicate-aware event handler overloads, transition handling, malformed-object hardening, and coverage.
brendandburns
force-pushed
the
fix-predicate-informer-event-handlers
branch
from
September 1, 2026 19:49
ea2cb84 to
c6f6bb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits predicate-aware informer event-handler changes out of #4892.
Summary
FilteringResourceEventHandlerValidation
./mvnw -q -pl util,e2e -am compile test-compile -DskipTests