Repository navigation
feat: add video events to /v2/events - #208
Merged
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Phfollert
reviewed
Oct 13, 2026
Phfollert
left a comment
Phfollert
left a comment
Contributor
There was a problem hiding this comment.
missing invalid_video_event_type
Contributor
Author
|
@Phfollert added |
Phfollert
approved these changes
Oct 13, 2026
Phfollert
left a comment
Phfollert
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Spec matches the auction-engine /v2/events video handling.
celzo
approved these changes
Oct 13, 2026
Document the `videoEvents` array and the `VideoEvent` schema shipped in auction-engine #5164 and gated in #5225. INTE-1541 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
INTE-1541 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
INTE-1541 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
anonvt
force-pushed
the
feat/video-events
branch
from
October 13, 2026 21:57
75ce850 to
730c81b
Compare
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the new
videoEventsarray in the public Events API (/v2/events), so marketplaces running sponsored video ads can report VAST playback checkpoints and delivery failures. Ticket: INTE-1541.Changes (
topsort-api-v2.yml)/v2/events: add a Video events bullet and update the request-body description.EventsRequest: add avideoEventsarray (maxItems: 50).VideoEventschema:resolvedBidId/eventType/occurredAt/opaqueUserId/idrequired;errorCode/placement/page/deviceType/channeloptional.eventTypeenum isstart,firstQuartile,midpoint,thirdQuartile,complete,error.errorCodeis required wheneventTypeiserrorand ignored otherwise, stated in prose rather thanif/thento match how the rest of the file expresses conditional fields.Validation
videoEvents(binding:"max=50"),VideoEventfields and required flags perbehavior-data-service/bdssrv/v2/model_video.go, enum perbs.VideoEventType,errorCoderule per themissing_video_error_codecheck inevents_handler.go, and the non-video bid rejection (non_video_resolved_bid) from auction-engine #5225.prettier --check,yamllint,typosclean.vacuum lintpasses with 0 errors.redocly lint --extends recommended-strictreports the same 4 pre-existingTravelAuctionRequest/TravelAuctionResultoneOferrors asmain; nothing new.Note
Video events are accepted only when the
resolvedBidIddecodes to a video bid. That gate (auction-engine #5225) is fed by central-services #10924 and auction-engine #5265, both merged in September, so the endpoint is live for video campaigns.🤖 Generated with Claude Code