Repository navigation
Conversation
The Redocly check has failed on every PR since the travel auction schemas landed, over four no-illogical-composition-keywords findings on TravelAuctionRequest and TravelAuctionResult. Fixing them properly means reshaping those contracts, so ignore exactly these four until that happens and let the check go green for unrelated changes. INTE-1541 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
Closing: these findings should be fixed in the travel schemas themselves ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Redocly's own
.redocly.lint-ignore.yaml, generated withredocly lint --generate-ignore-file, scoped to the fourno-illogical-composition-keywordsfindings onTravelAuctionRequest/oneOfandTravelAuctionResult/oneOf. Ticket: INTE-1541.Why
The Redocly check has been red on
mainand on every PR since the travel auction schemas landed (#206 failed the same way). Fixing the findings properly means changing the travel contracts: makingtyperequired onHotelsAuctionRequest/FlightsAuctionRequest, and constrainingresultTypeon the result schemas, whereEmptyAuctionResultoverlaps with the others by design. That needs the travel owner, so this scopes the ignore to exactly those four paths and lets unrelated PRs such as #208 go green. Any new Redocly finding elsewhere still fails.Validation
redocly lint --extends recommended-strictnow reports "4 problems are explicitly ignored" and no errors.prettier --checkandyamllintpass.🤖 Generated with Claude Code