Repository navigation
Conversation
anonvt
force-pushed
the
chore/drop-errcode-enum
branch
from
October 13, 2026 19:24
caa6a72 to
feadcca
Compare
anonvt
force-pushed
the
feat/video-events
branch
from
October 13, 2026 21:57
75ce850 to
730c81b
Compare
anonvt
force-pushed
the
chore/drop-errcode-enum
branch
from
October 13, 2026 21:57
feadcca to
459bd5d
Compare
The enum had drifted from auction-engine (dozens of returned codes unlisted) and will not be kept in sync. Keep errCode as a free string with examples so generated clients never fail to parse a 400. INTE-1541 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
anonvt
force-pushed
the
chore/drop-errcode-enum
branch
from
October 13, 2026 23:24
459bd5d to
38f9097
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the closed
enumfromError.errCode, keeping it a free string with examples. Stacked on #208. Ticket: INTE-1541.Why
Sentry flagged on #208 that new error codes were missing from the enum. Checking the list showed it has drifted well past that: around 44 codes auction-engine returns today are not listed, and about 19 listed codes no longer appear in auction-engine. Pato's call is that the enum will not be maintained, so a closed list only puts strict generated clients at risk of failing to parse a
400whenever a new code appears. Themessagefield already says clients must not dispatch on its value;errCodestays the stable identifier, just not as a closed set.Validation
prettier --check,yamllintandvacuum lint(0 errors) pass.redocly lint --extends recommended-strictreports the same 4 pre-existingTravelAuction*oneOferrors asmain.🤖 Generated with Claude Code