FPO++'s optimizer, gradient clipping, advantage normalisation and Huber CFM loss, as options - #91
Merged
Merged
Conversation
…er CFM loss, as options
E37 ran FPO++'s policy loss on square from a behaviour-cloned start and the
policy fell from 0.50 to 0.24-0.42 over fifty evaluation episodes, while its
randomly initialised critic never fit the returns. FPO++'s square fine-tuning
(amazon-far/fpo-control, manipulation_experiments/finetune_online_rl.py) has
more than the loss, and this adds the rest, each off by default:
critic_learning_rate, adam_eps, weight_decay, actor_adam_beta2
two AdamW groups (FPO++: actor 1e-5 betas (0.9, 0.99), critic 1e-4,
eps 1e-5, weight decay 1e-6); left at their defaults, FPO's one Adam.
During a critic warmup the actor's group gets no gradient at all, so
weight decay cannot move it.
max_grad_norm
the actor's and the critic's gradients clipped separately (FPO++: 25);
their pre-clip maxima are logged.
normalize_advantage_per_minibatch
as FPO++ does, instead of over the buffer.
cfm_loss_huber_delta
FPO++'s Huber on the flow-matching error, d^2 within delta and
2 delta |d| - delta^2 beyond (FPO++: 1).
FPO's learn step now also reports the critic's explained variance, which
DPPO always has and E37 could not read.
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E37 (#89) fine-tuned a behaviour-cloned
fpo-policyon square with FPO++'s policy loss. Over fifty evaluation episodes it fell from 0.50 to 0.24–0.42, while DPPO took the same clone to 0.78–0.90. The randomly initialised critic never fit the returns. That run had only FPO++'s loss. FPO++'s square fine-tuning (amazon-far/fpo-control,manipulation_experiments/finetune_online_rl.py, read for facts, nothing copied) also has the following. Each is now an option, off by default:critic_learning_rate,adam_eps,weight_decay,actor_adam_beta2max_grad_normnormalize_advantage_per_minibatchcfm_loss_huber_deltaTwo details:
rollout/, as DPPO always has. E37 could not read it.tests/test_fpo_plus_plus_optimizer.pyhas 17 tests:fpo_playground_trickThe one source-inspection test that forbids normalising inside
_compute_lossstill holds by default. The opt-in goes through_minibatch_advantage, and that test's docstring now says so. Full suite: 287 passed, 3 skipped.E39, which runs these on square, is next (
exp/e39-square-fpo-plus-plus, stacked on this).