WIP: set engineStrict config when package manager is pnpm

.changeset/early-kiwis-drum.md

@@ -0,0 +1,6 @@
+---
+"sv": patch
+---
+
+fix(sv): templates set `engineStrict` in `pnpm-workspace.yaml` when package manager is `pnpm`
+

packages/sv-utils/src/tests/transforms.ts

@@ -165,7 +165,7 @@ describe('transforms', () => {
 			expect(result).toContain('name: new');
 		});
 
-		it('abort: returns fals if transform is cacelled', () => {
+		it('abort: returns false if transform is cancelled', () => {
 			const input = 'name: old\n';
 			expect(transforms.yaml(() => false)(input)).toBe(false);
 		});
@@ -180,7 +180,7 @@ describe('transforms', () => {
 			expect(result).toContain('name = "new"');
 		});
 
-		it('abort: returns fals if transform is cacelled', () => {
+		it('abort: returns false if transform is cancelled', () => {
 			const input = 'name = "old"\n';
 			expect(transforms.toml(() => false)(input)).toBe(false);
 		});

packages/sv/src/cli/create.ts

@@ -17,6 +17,7 @@ import { formatFiles } from '../core/formatFiles.ts';
 import {
 	AGENT_NAMES,
 	addAllowBuildsIfPnpm,
+	addEngineStrict,
 	detectPackageManager,
 	installDependencies,
 	installOption,
@@ -416,6 +417,7 @@ export async function createProject(cwd: ProjectPath, options: Options) {
 
 	const addOnNextSteps = getNextSteps(addOnSuccessfulAddons, workspace, answers, addonSetupResults);
 
+	addEngineStrict({ cwd: projectPath, packageManager });
 	addAllowBuildsIfPnpm({ cwd: projectPath, packageManager, packages: ['esbuild'] });
 
 	let depsInstalled = false;

packages/sv/src/core/package-manager.ts

@@ -9,7 +9,9 @@ import {
 	color,
 	detect,
 	pnpm,
-	resolveCommand
+	resolveCommand,
+	transforms,
+	type TransformFn
 } from '@sveltejs/sv-utils';
 import { Option } from 'commander';
 import * as find from 'empathic/find';
@@ -146,3 +148,81 @@ export function addAllowBuildsIfPnpm(options: {
 	const newContent = pnpm.allowBuilds({ cwd, packages })(content);
 	if (newContent && newContent !== content) fs.writeFileSync(filePath, newContent, 'utf-8');
 }
+
+/**
+ * add engine strict configuration according to selected package manager
+ */
+export function addEngineStrict(options: {
+	cwd: string;
+	packageManager: AgentName | null | undefined;
+}) {
+	switch (options.packageManager) {
+		case 'pnpm':
+			addEngineStrictForPnpm(options);
+			break;
+		default:
+			addEngineStrictForNpm(options);
+			break;
+	}
+}
+
+/**
+ * adds `engineStrict` to `pnpm-workspace.yaml` if not set.
+ * creates the file if it does not exist.
+ */
+export function addEngineStrictForPnpm(options: {
+	cwd: string;
+	packageManager: AgentName | null | undefined;
+}): void {
+	const { cwd, packageManager } = options;
+	if (packageManager !== 'pnpm') return;
+
+	const found = find.up('pnpm-workspace.yaml', { cwd });
+	const filePath = found ?? path.join(cwd, 'pnpm-workspace.yaml');
+	const content = found ? fs.readFileSync(found, 'utf-8') : '';
+
+	function writeEngineStrict(): TransformFn {
+		return transforms.yaml(({ data }) => {
+			const existing = data.get('engineStrict');
+			if (existing !== undefined) {
+				return false;
+			}
+			data.set('engineStrict', true);
+		});
+	}
+
+	const newContent = writeEngineStrict()(content);
+
+	if (newContent && newContent !== content) fs.writeFileSync(filePath, newContent, 'utf-8');
+}
+
+/**
+ * adds `engine-strict` to `.npmrc` if not set.
+ * creates the file if it does not exist.
+ */
+export function addEngineStrictForNpm(options: {
+	cwd: string;
+	packageManager: AgentName | null | undefined;
+}): void {
+	const { cwd, packageManager } = options;
+	if (packageManager === 'pnpm') return;
+
+	const found = find.up('.npmrc', { cwd });
+	const filePath = found ?? path.join(cwd, '.npmrc');
+	const content = found ? fs.readFileSync(found, 'utf-8') : '';
+
+	function writeEngineStrict(): TransformFn {
+		return transforms.text(({ content, text }) => {
+			const existing = content.includes('engine-strict');
+			if (existing) {
+				return false;
+			}
+			console.log('adding engine-strict=true');
+			return text.upsert(content, 'engine-strict', { value: 'true' });
+		});
+	}
+
+	const newContent = writeEngineStrict()(content);
+
+	if (newContent && newContent !== content) fs.writeFileSync(filePath, newContent, 'utf-8');
+}