WIP: set engineStrict config when package manager is pnpm by pluxain · Pull Request #1344 · sveltejs/cli

pluxain · 2026-09-29T13:46:51Z

Description

Following the allowBuilds approach, we add the engineStrict config to the pnpm-workspace.yml if it is not already set.

Checklist

Update snapshots (if applicable)
Add a changeset (if applicable)
Allow maintainers to edit this PR
I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

pkg-svelte-dev · 2026-09-29T13:46:55Z

Install the latest version of sv from b0bf634:

pnx https://pkg.svelte.dev/sv/c/b0bf634c2084b7aea2783128a3ad396422de0f7f create

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/cli/pr/1344

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

changeset-bot · 2026-09-29T13:46:57Z

🦋 Changeset detected

Latest commit: b0bf634

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
sv	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pluxain · 2026-09-29T13:48:55Z

Hi, this is my first attempt to contribute to the project. I followed what was done for allowBuilds.

I miss some things though: for instance I could not run the branch locally to see if the generated project output was correct.

I also do not know if I should regenerate the snapshots or the changeset.

Any guidance is welcome! Cheers!

sacrosanctic · 2026-09-30T20:50:35Z

allowBuilds is public because add-on developers would use it for their own app. But I don't see why this needs to be public. It's just for scaffolding brand now templates.

As an aside, I didn't want to fix it cause the whole create logic should be rewritten which would make this a no brainer fix.

manuel3108 · 2026-10-01T07:33:22Z

Hi, this is my first attempt to contribute to the project

Thanks for helping out!

I miss some things though: for instance I could not run the branch locally to see if the generated project output was correct.

What exactly was not working? Im pretty sure we are just missing something CONTRIBUTING.md

Snapshots should indeed be regenerated. Also a changeset is required here, since this is a public facing change, otherwise no new release will be triggered.

pluxain · 2026-10-01T12:54:29Z

What exactly was not working? Im pretty sure we are just missing something CONTRIBUTING.md

CONTRIBUTING.md says:

## Build and run

To build the project and all packages. Run the 'build' script:

```sh
# from root of project
pnpm build
```

This outputs into /packages/PACKAGE/dist/.

Run the 'cli' package:

```sh
pnpm sv
pnpm sv create
pnpm sv add
pnpm sv migrate
pnpm sv check
pnpm sv help
```

So I thought I should buid the project locally and run pnpm sv create but then I get this output:

[ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL] Command "sv" not found

pluxain · 2026-10-01T12:59:23Z

Also, when I try to regenerate the snapshots, using this (taken from the CONTRIBUTING.md file again):

pnpm build && pnpm test --project cli --update all

I receive this output and it runs forever:

$ vitest run --silent --project cli --update all

 RUN  v4.1.8 /home/calou/dev/@sveltejs/cli

│
■  The --tasks values all and prerequisite cannot be combined with other tasks.
│
└  Operation failed.

│
■  The --tasks values all and prerequisite cannot be combined with other tasks.
│
└  Operation failed.

│
■  Unknown migration task: missing
│  Available tasks: svelte-config, env-vars
│
└  Operation failed.

 ✓  cli  tests/migrate.ts (13 tests) 19ms

 ❯  cli  tests/cli.ts 2/5

 Test Files 1 passed (2)
      Tests 15 passed (18)
   Start at 14:55:24
   Duration 138.01s

sacrosanctic · 2026-10-01T13:05:59Z

That's a visual bug. I fixed it in the other PR.

sacrosanctic · 2026-10-01T13:07:16Z

[ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL] Command "sv" not found

This should work. What version of pnpm are you on and what folder did you run it in. Should be pnpm 11 and root respectively.

pluxain · 2026-10-01T13:12:06Z

run at the root of the project:

 pnpm --version

gives

11.27.1

(I removed the warning about packageManager and devEngines.packageManager specifying a different version.

But anywhere else on my machine:

 pnpm --version

yields

12.4.2

jycouet · 2026-10-01T13:19:59Z

TBH, I never use pnpm sv but always pnpm build && node ./packages/sv/dist/bin.mjs (from repo root).
Like this I'm using "raw node". I also had issues in the past with pnpm sv with a global installation.

Maybe we should tweak this in the readme? WDYT?

sacrosanctic · 2026-10-01T13:30:13Z

pnpm bootstraps node to the correct version we pinned. Which also means pnpm sv works whether you have a different version installed in global or none installed at all.

I think pnpm 11 works a lot better so I rather triage the problem.

pluxain · 2026-10-02T12:12:34Z

allowBuilds is public because add-on developers would use it for their own app. But I don't see why this needs to be public. It's just for scaffolding brand now templates.

As an aside, I didn't want to fix it cause the whole create logic should be rewritten which would make this a no brainer fix.

Hi Scott,

Do you mean in this case everything should happen in addEngineStrictIfPnpm ?

I tried to follow the approach for allowBuilds as I wasn't sure of why it is structure like that.

As I stated in my comment, I would rather have the engineStrict added in the pnpm-workspace.yml with allowBuilds in one go to avoid writing the file over. I do not want to have a misleading name addAllowBuildsIfPnpm which also have a side effect on engineStrict config. What do you say ?

sacrosanctic · 2026-10-02T13:36:57Z

Do you mean in this case everything should happen in addEngineStrictIfPnpm ?

Yes, keep it private.

one go to avoid writing the file over

You can write to the same file multiple times. We do it all the time in this codebase.

ref sveltejs#1341

ref sveltejs#1341 - followed the same approach as `allowBuilds`

ref sveltejs#1341

sacrosanctic · 2026-10-05T08:04:33Z

+export function writeEngineStrict(): TransformFn {
+	return transforms.yaml(({ data }) => {
+		const existing = data.get('engineStrict');
+		// if not set, set to true


Suggested change

// if not set, set to true

sacrosanctic · 2026-10-05T08:06:01Z

+
+/**
+ * Returns a TransformFn for `pnpm-workspace.yaml` that adds `engineStrict` config
+ * if not defined already
+ */
+export function engineStrict(): TransformFn {
+	return writeEngineStrict();
+}


remove from sv-utils

sacrosanctic · 2026-10-05T08:08:07Z

+	packageManager: AgentName | null | undefined;
+}): void {
+	const { cwd, packageManager } = options;
+	if (packageManager !== 'pnpm') return;


remove the config from .npmrc

If I understand correctly, .npmrc files are present in templates and only contain engine-strict=true.

Maybe we can remove the .npmrc completely when the package manager is pnpm ? @see https://pnpm.io/blog/releases/11.0#npmrc-is-authregistry-only

That is fine. Something along the lines of: remove prop, if file is empty, delete file. In case we add other props in the future.

Co-authored-by: Scott Wu <sw@scottwu.ca>

pluxain commented Sep 30, 2026

View reviewed changes

Comment thread packages/sv/src/cli/create.ts

pluxain marked this pull request as draft September 30, 2026 07:27

sacrosanctic reviewed Oct 1, 2026

View reviewed changes

Comment thread packages/sv-utils/src/pnpm-internals.ts Outdated

Comment thread packages/sv-utils/src/pnpm.ts Outdated

Comment thread packages/sv/src/cli/create.ts

manuel3108 changed the base branch from version-1 to main October 3, 2026 08:04

pluxain added 5 commits October 5, 2026 09:02

fix typo in existing tests

f554e8e

ref sveltejs#1341

add pnpm internal for engineStrict

0faf1ae

ref sveltejs#1341

wrap pnpm internal in pnpm and package-manager

9a22e94

ref sveltejs#1341 - followed the same approach as `allowBuilds`

add changeset

5ae2b29

ref sveltejs#1341

ref(tech): follow code convention for undefined

ad3bd63

ref sveltejs#1341

pluxain force-pushed the f/engine-strict-pnpm branch from be05ed9 to ad3bd63 Compare October 5, 2026 07:25

write engineStrict to pnpm-workspace.yaml internally

b209ae8

ref sveltejs#1341

sacrosanctic reviewed Oct 5, 2026

View reviewed changes

Apply batched suggestions from code review

b0bf634

Co-authored-by: Scott Wu <sw@scottwu.ca>

Uh oh!

Conversation

pluxain commented Sep 29, 2026

Description

Checklist

Uh oh!

pkg-svelte-dev Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pluxain commented Sep 29, 2026

Uh oh!

Uh oh!

sacrosanctic commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manuel3108 commented Oct 1, 2026

Uh oh!

pluxain commented Oct 1, 2026

Uh oh!

pluxain commented Oct 1, 2026

Uh oh!

sacrosanctic commented Oct 1, 2026

Uh oh!

sacrosanctic commented Oct 1, 2026

Uh oh!

pluxain commented Oct 1, 2026

Uh oh!

jycouet commented Oct 1, 2026

Uh oh!

sacrosanctic commented Oct 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pluxain commented Oct 2, 2026

Uh oh!

sacrosanctic commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sacrosanctic Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

sacrosanctic Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

sacrosanctic Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

pluxain Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

sacrosanctic Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pkg-svelte-dev Bot commented Sep 29, 2026 •

edited

Loading

changeset-bot Bot commented Sep 29, 2026 •

edited

Loading

sacrosanctic commented Sep 30, 2026 •

edited

Loading

sacrosanctic commented Oct 2, 2026 •

edited

Loading