Repository navigation
fix(opencode): show inline HTML visualizations - #25827
Closed
joaomendoncaa wants to merge 1 commit into
Closed
joaomendoncaa wants to merge 1 commit into
joaomendoncaa wants to merge 1 commit into
Conversation
OpenCode passed html_render's attachment reference through as text, and Code Mode nests it under the execute result, so the client never saw the reference. Reattach it in both adapters and lift nested references into normal html_render items.
Author
Verification
No UI changes. This is a focused fix for an obvious bug: the same feature already works for ACP/Antigravity, and OpenCode is the only adapter that does not reattach the reference. No prior issue. I did not manually drive a non-Code-Mode OpenCode session, but that path is covered by the adapter test. |
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a scoped OpenCode adapter fix that restores existing inline HTML visualization references for direct and nested tool calls. The bounded extraction logic is covered by shared-library and adapter regression tests, with no production defaults or infrastructure changes. You can add or adjust custom eligibility rules. Learn more. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCode drops the
htmlRenderreference returned by T3'shtml_rendertool, both on direct MCP calls and when Code Mode nests it underexecute, so inline HTML visualizations never appear. This reattaches the published reference in both OpenCode adapters and lifts nested references into normalhtml_renderitems, with regression tests.DeepSeek V4.1 Flash via OpenCode Go