Skip to content

Guard each author counter on its own when decrementing #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMattPro merged 1 commit into from
Aug 6, 2026
+23 −4
Merged

Guard each author counter on its own when decrementing #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions includes/objects/contribution.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1998,12 +1998,31 @@ private function change_author_contrib_count($user_id, $action = '+', $force = f
$user_id = (int) $user_id;
$action = ($action == '-') ? '-' : '+';

if ($action == '-')
{
// Guard each counter on its own; the columns are unsigned, so a
// counter that is already at zero must not fail the whole update.
$sql_set = 'author_contribs = CASE WHEN author_contribs > 0 THEN author_contribs - 1 ELSE 0 END';

if (isset($this->type->author_count))
{
$sql_set .= ', ' . $this->type->author_count . ' = CASE WHEN ' . $this->type->author_count . ' > 0 THEN ' . $this->type->author_count . ' - 1 ELSE 0 END';
}
}
else
{
$sql_set = 'author_contribs = author_contribs + 1';

if (isset($this->type->author_count))
{
$sql_set .= ', ' . $this->type->author_count . ' = ' . $this->type->author_count . ' + 1';
}
}

// Increment/Decrement the contrib counter for the new owner
$sql = 'UPDATE ' . TITANIA_AUTHORS_TABLE . "
SET author_contribs = author_contribs $action 1" .
((isset($this->type->author_count)) ? ', ' . $this->type->author_count . ' = ' . $this->type->author_count . " $action 1" : '') . "
WHERE user_id = $user_id " .
(($action == '-') ? 'AND author_contribs > 0' : '');
SET $sql_set
WHERE user_id = $user_id";
phpbb::$db->sql_query($sql);


Expand Down