Guard each author counter on its own when decrementing - #456
Merged
Conversation
The decrement update subtracted from author_contribs and from the per-type counter in one statement, guarded only by author_contribs being above zero. The columns are unsigned, so once a per-type counter has drifted to zero the subtraction fails and the whole action dies with an SQL error: changing the contribution status, changing its owner or deleting it. Each counter now stops at zero on its own, which also lets a drifted counter correct itself over time instead of the skipped update pushing them further apart.
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents unsigned author counters from underflowing during contribution decrements.
Changes:
- Guards total and per-type counters independently.
- Preserves existing increment behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455
The decrement guarded only author_contribs, so a per-type counter already at zero made the unsigned subtraction fail and the whole action die with an SQL error. Each counter now stops at zero on its own, which also lets a drifted counter come back into step over time instead of the skipped update pushing the two further apart.