Repository navigation
test: give the rtbtool smoke tests 40 s, not 15 s, to start - #893
Merged
Merged
Conversation
petercorke
enabled auto-merge (squash)
October 22, 2026 23:57
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 146 146
Lines 16684 16684
=====================================
Misses 16684 16684 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The timeout for the
rtbtoolsubprocess tests intests/test_bin.pygoes from 15 s to 40 s.Why
Starting
rtbtoolimports RTB and IPython. On the Windows runner that took over 15 s and failedtest_options_envvarandtest_run_scripttwice in one day, on #888 (Python 3.13) and on #890 (3.12), withsubprocess.TimeoutExpired. Nothing in either PR touched this code, and a rerun passed. CI stops a test at 50 s, so 40 s still leaves the subprocess timeout as the one that fires.No code changes, only a test constant. All 7 tests in the file pass locally (11 s).
🤖 Generated with Claude Code