Repository navigation
feat(ets): a trailing underscore numbers a joint name from one; document joint descriptors - #811
Merged
Merged
Conversation
…es included Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ent joint descriptors A joint descriptor such as "A1" has jindex 1, the digits as written, so the names A1 to A6 of a Kuka arm gave indices 1 to 6, which a robot rejects. "A1_" is joint 0: the underscore says the name counts from one, and is not part of the displayed name. "A0_" is an error. The Unicode minus sign negates a joint like the hyphen. The descriptors were documented only in code comments. They are now described in the BaseET docstring, with the minus sign, and linked from the parameter of each ET and ET2 constructor. A robot whose joint indices are exactly 1 to n gets an error message that says to use the underscore. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 14 high |
🟢 Metrics 35 complexity · 0 duplication
Metric Results Complexity 35 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 144 144
Lines 14917 14931 +14
=====================================
- Misses 14917 14931 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A joint descriptor such as
"A1"has joint index 1, the digits as written, so the namesA1toA6of a Kuka arm gave indices 1 to 6, which a robot rejects with an unhelpful message. A trailing underscore now says the name counts from one:"A1_"is joint 0,"-A1_"is joint 0 flipped,"θ2_"is joint 1. The underscore is an instruction and is not shown,Rz(A1)."A0_"is an error.−negates a joint like-; it silently did not before.BaseETdocstring (index, sign, one-based names, no-number and constant cases, the conflict rule), and eachETandET2constructor'sparamline links to it.No hidden renumbering: indices are as written unless the user adds the underscore.
Tests
tests/test_et_joint_descriptor.py, written first (25 of 45 failed onmain): 24 descriptor forms, all sixETconstructors andET2, the zero and conflict errors, numeric strings, flip semantics, and a 6-jointERobotfromA1_..A6_giving the samefkineandjacob0asq0..q5, with one joint flipped. The existing descriptor tests intest_ET.pyandtest_ETS.pypass unchanged.Full suite: same 29 failures as
mainhere (stale compiled extension). mypy clean on 164 files.Related issue
Issue #803 (joint-index resolver). One observation recorded there: an ETS whose jindices are not a permutation of
0..n-1evaluatesfkinein joint order and ignores the numbers.🤖 Generated with Claude Code