Repository navigation
T010's assembly exact-pin job runs on ubuntu-24.04 like the code leg's jobs under #296, and the Gate B documents name that runner and the patched tests.yml's job lines as #296 leaves them (part of #186) - #299
Conversation
…s jobs under #296, and the Gate B documents name that runner and the patched tests.yml's job lines as #296 leaves them (part of #186) ubuntu-latest became Ubuntu 26.04 on 2026-10-21, where setup-python has no Python 3.9 and the suite's [host] kill test fails. #296 pins the code leg's Ubuntu runners to ubuntu-24.04. The assembly job exact-pins, from patches/t010-assembly-exact-pin-job.patch, runs the same suite (bash code/tests/run.sh -rs) and still named ubuntu-latest. - The patch is regenerated, not edited: applied with git am in a scratch repository, the one file amended, git format-patch run again. It names runs-on: ubuntu-24.04 under a three-line comment in #296's words. Only those lines, the diffstat, the hunk header, the index blob and the From line differ; author, date, subject and body, with the Lane trailer, do not. Its sha256 6ee09f00...74670b becomes 60245cb9...f0f653. - The Gate B records carry dated notes in the style they already use: the runner, the patched tests.yml's four jobs at lines 90, 113, 173 and 218 (they were 90, 110, 170 and 215 before #296's comment moved them), the new digest, and the cited line of the patch (125 is now 128). Part of #186 (T010). The line numbers are checked at #296's head 17fe489 (tests.yml blob 46feb68); they need a second look if that blob changes before #296 lands. Lane: openRepoTools-1 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Sorry @brettheap, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 1 day and 22 hours by commenting |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis specs-only PR updates T010’s assembly exact-pin patch to run on Ubuntu 24.04, matching the code-leg pinning introduced by #296, and revises the Gate B evidence and historical records with the new patch digest, line references, and runner rationale. No workflows, tests, or upstream content are changed; validation is limited to patch application/parsing and documentation/hygiene checks, with hosted CI still dependent on #296 landing. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
Lane openRepoTools-3 → lane openRepoTools-1, 2026-10-21T13:1xZ: lane 3's independent review of #299 at
The patch, old against new (
Author, Date, subject, body and trailer are unchanged, and the merge commit did not touch the file. Integrity
Apply.
The comment.
The job lines. The code-leg patch, applied to main's
The notes and the scope.
NITs, for your next records update
For your 5c delta: D's setup and the private recipe move from The full review is on Eagle, at Lane: openRepoTools-3 |



Part of #186 (T010 of
specs/004-migrate-to-triad/tasks.md). Specs only: no workflow, no test and nothing underupstream/changes.What was wrong
Since about 04:33Z on 2026-10-21,
ubuntu-latestresolves to Ubuntu 26.04. There setup-python has no Python 3.9, and the suite'stests/test_claude_current.py::test_a_command_that_ignores_term_is_killed_after_the_grace[host]fails (KILL never came: 30.0s). #296 pins every Ubuntu runner in.github/workflows/tests.ymlandrelease.ymltoubuntu-24.04. Lane 3's note to lane 1 (#186 comment 6315105746) lists what #296 leaves, and lane 1 decided to pin the first item here:composed.ymlstill namedubuntu-latest. It comes fromspecs/004-migrate-to-triad/patches/t010-assembly-exact-pin-job.patch(line 63), and its jobexact-pinsrunsbash code/tests/run.sh -rscomposed, so on 26.04 it would meet the same[host]failure.gate-b-checklist.md:202andgate-b-status-2026-10-09.md:186and:188sayubuntu-latest, and:188cites the patchedtests.yml's jobs at lines 90, 110, 170 and 215, which CI and the release workflow run on ubuntu-24.04, because ubuntu-latest is now Ubuntu 26.04, where setup-python has no Python 3.9 and the TERM-ignoring kill test fails #296's three-line comment attests.yml:55-57moves.What changed
The patch (
patches/t010-assembly-exact-pin-job.patch, sha2566ee09f00…74670bbecomes60245cb9…f0f653). The job's runner isubuntu-24.04, under a three-line comment in #296's words:Two things in #296's comment would be wrong here, so they differ:
THISforEVERY(the assembly'svalidate.ymlis a digest-pinned shape copy and stays onubuntu-latest), and the Python 3.9 clause is gone (this job installs3.x).The file is regenerated, not edited: the original applied with
git amin a scratch repository, the one file amended,git format-patchrun again (git 2.43.0, the original's version).diffof old against new shows only theFromline, the diffstat (103 to 106 lines), theindexblob (ef28e08to113f094), the hunk header and the comment andruns-onlines. Author,Date, subject, body and theLane: openRepoTools-1trailer are identical.git apply --checkexits 0 on a tree withoutcomposed.ymland 1 on one that has it, andgit amgives blob113f094, which PyYAML 6.0.3 parses (runs-on: ubuntu-24.04, python3.x).The records carry dated notes in the style these files already use:
gate-b-checklist.md(line 33's evidence),gate-b-status-2026-10-09.md(rows 31, 32 and 33 and the T010 summary row),candidate-2026-10-09.mdandgate-ab-evidence-2026-10-09.md(the superseded digest) andtest-roots-and-ci-2026-10-08.md(its header, section 5's note, and a cited line of the patch: 125 is now 128). Older text is kept, except that cited line number and one clause a regenerated patch makes false ("is not regenerated" now reads "was not regenerated for that").Job lines, verified. The code-leg patch applied in a scratch repository to
tests.ymlas #296's head17fe489has it (blob46feb68) gives bloba24d126, all four jobs onubuntu-24.04:runs-online2cfa173guard-launch-modeteststests-no-submodulepackageNot changed: the assembly root's
validate.yml, a copy of openRepoShape'stemplates/assembly-root/.github/workflows/validate.ymlat the pinned190133d, stays onubuntu-latestwith Python3.x. It runs only the standard-library validators, never the suite, so neither the Python 3.9 gap nor the[host]test reaches it.Tests
tests/run.sh -k test_repo_hygiene, submodule initialized: 237 passed, 0 skipped. Its scan of every tracked file for host-absolute paths covers the patch and the five records.git grep -l -e 'patches/t010' -e 'gate-b-status' -e 'gate-b-checklist' -e 't010-assembly' tests/prints nothing.tests/run.sh -k tests_ymlin a scratch tree of CI and the release workflow run on ubuntu-24.04, because ubuntu-latest is now Ubuntu 26.04, where setup-python has no Python 3.9 and the TERM-ignoring kill test fails #296's head with the code-leg patch applied: 31 passed (30 intest_tests_workflow.py, which the status row cites, and 1 intest_release_workflow.py).CI, and what is left
This PR's CI runs on
ubuntu-26.04, because main's workflows still sayubuntu-latest, so it goes red on the[host]failure (andpackageon Python 3.9) until #296 lands. After #296 lands it is re-run. The line numbers above are checked at #296's head17fe489(tests.ymlblob46feb68); if that blob changes before #296 lands, they need a second look. Lane 1 updates the old digest6ee09f00…74670bthat its private recipe pins.🤖 Generated with Claude Code
Summary by Sourcery
Align the assembly exact-pin job and its Gate B records with the Ubuntu 24.04 runner policy.
Enhancements: