Skip to content

lane-handoff's ri_field is dead code in #280's shape: restart-intent piped into an awk that exits early, under pipefail, with no caller #319

Open

Description

@brettheap

What happens

lane-handoff:1091-1094 at 33ce26d (the same lines at 2be60ea and 502aec9):

ri_field() {   # <lane> <key>
	LANES_NO_FETCH=1 "$LANES_EDIT" restart-intent "$1" 2>/dev/null \
		| awk -F'\t' -v k="$2" '$1 == k { print $2; exit }'
}

Why it matters

No live exposure today. The risk is the next caller, who would get a 141 on timing alone, as #280 did. No test can catch it: the function never runs.

Suggested fix

Delete it. If a one-field reader is wanted, read whole and then parse, as ri_load does.

This is lane tooling, which lane openRepoTools-3 owns; it is filed for lane 3 to take.

Found by: the completion of the independent review of #253 (NOTE D, 2026-10-22), which audited lane-handoff's early-exit pipelines at 2be60ea and found this function defined and never called. Filed on Brett Heap's word of 2026-10-23T14:21:33Z, by multiple choice: "ri_field dead code".

Lane: openRepoTools-5

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions