Skip to content

tests-macos: test_a_path_that_is_not_utf8_is_a_row_not_a_traceback cannot build its fixture on APFS (git worktree add refuses the non-UTF-8 path) #177

Description

@brettheap

On the ready gate run of #168 (head df0d691, run 37492625698, job 112368980621) tests-macos ended 1 failed, 1160 passed in 1:55:25. The one failure is #168's own test tests/test_lane_worktrees.py::test_a_path_that_is_not_utf8_is_a_row_not_a_traceback: its fixture runs git worktree add with a path containing a non-UTF-8 byte and git on macOS (APFS, which only stores valid UTF-8 names) refuses it with subprocess.CalledProcessError before the assertion under test is reached.

The tool under test is fine; the fixture cannot exist on that filesystem. Fix: build the non-UTF-8 directory with the raw bytes name first and pytest.skip("filesystem refuses non-UTF-8 names") when that OSErrors or when git refuses the worktree add; keep the test live on Linux (where it proves B2 of the Opus review).

Filed as the landing-gate follow-up of #168 under Brett Heap's ruling 1 of 2026-09-16 pending his word on where the fix lands (#168's head, or the #169 fold-in that follows it).

Lane: openRepoTools-3

Activity

  1. brettheap commented on Oct 6, 2026

    @brettheap
    ContributorAuthor

    CLAIMED — lane openRepoTools-3, session 83619980-06bb-4469-ae73-2a8c5e61981a@Eagle, 2026-10-06T18:04:03Z, for #177

    Logged in lanes/log/openRepoTools-3.md at 2f11530072e1eaf49f22fa37752f8dc9749a9b99.

    The three reads (lane-collision-protocol Rule 1):

    1. existing `CLAIMED —` comments on opensoft/openRepoTools#177:
       none
    2. `gh pr list --repo opensoft/openRepoTools --state all --search "#177"`, kept where the row or its body names `#177`:
       none
    3. `git ls-remote --heads git@github.com:opensoft/openRepoTools` branches naming `177` as a whole token:
       none
    
  2. brettheap commented on Oct 6, 2026

    @brettheap
    ContributorAuthor

    Fixed by the skip guard that rode in #169 (commit d2f8051 'Skip the non-UTF-8 path case where the filesystem refuses the name'), squashed into main as 500687c; #169's body did not carry a Closes line, so this is closed by hand. Lane: openRepoTools-3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions