[objectstack-fleet]

Fixes #2161
Clause-②: no

What this changes

This carries out the maintainer's ruling A on the card (comment 6267342596). The accepted half of #1017's contact rule becomes a gate on the write that accepts the quote, and contact_integrity stops counting an accepted quote.

Where	Before	After
crm_quote.crm_contact requiredWhen (src/revenue/objects/quote.object.ts)	has(record.status) && (record.status == "presented" || record.status == "accepted")	has(record.status) && (record.status == "presented" || (record.status == "accepted" && (previous == null || !has(previous.status) || previous.status != "accepted"))). This is the ruled predicate, unchanged. next.5 has no declared transition-gate spelling: the field and state_machine schemas offer none.
contact_integrity quote count (src/sales/objects/contact.hook.ts)	$nin: ['rejected', 'expired']	$nin: ['accepted', 'rejected', 'expired']. Only open quotes hold a contact, as only open deals do.
The refusal sentence	"… 0 open opportunity(ies), 1 active quote(s), 0 active contract(s) … Close or reassign the opportunities and quotes first, …"	It names only what holds the contact, with real plurals ("1 open opportunity and 2 open quotes"), and only steps that free the contact. For a quote that means another contact, or rejecting it. Accepting it does not free the contact: the drafted contract names the same person and keeps its primary contact for life.
The Contact field's help text (description, en and zh-CN packs)	"Required once the quote is Presented or Accepted …" (an invariant reading)	"Required on the save that moves the quote to Presented or Accepted …". es-ES ("pasa a") and ja-JP ("になった時点で") already describe the gate and are unchanged.

Comment block on crm_contact: it now states the gate and why #720 and #1017 both hold. It also corrects the stale claim that an unevaluable predicate is skipped: since 17.0.0-rc.2 the write is rejected.

Riders (ruling item 5):

• the contact half of Browser pass #2058 — HotCRM-side defects (18 items: accepted quote still takes lines, half-converted leads, agents losing their cases, unreachable Sales Home, …) — list card, split per item at dispatch #2060 item 12 (A-17, the plural words). The campaign and product halves of that list item are untouched, and Browser pass #2058 — HotCRM-side defects (18 items: accepted quote still takes lines, half-converted leads, agents losing their cases, unreachable Sales Home, …) — list card, split per item at dispatch #2060 stays open;
• the stale "no cascade marker" note in contact.hook.ts (comment only): since 18.0.0-next.2 the platform declares ctx.referentialCascadeDelete, and this guard does not read it;
• content/docs/guides/import-and-export.mdx "Data deletion requests" (with both locale twins), checked against the new behaviour. content/docs/sales/quotes.mdx states the quote-contact rule and the accepted-quote freeze, so it is updated too (the freeze sentence in both twins as well).

Measurements (REST as a signed-up sales_manager, through the shared lock)

Shape	57d98535 (main, next.5)	this branch
Direct DELETE /data/crm_contact/ID, the only quote accepted	409 DELETE_RESTRICTED "… 1 active quote(s) …"	200. The quote is kept: status accepted, crm_contact null, every other column equal to before except updated_at / updated_by
DELETE /data/crm_account/ID, the accepted quote on another account	409, same sentence	200. The quote is kept on the other account with crm_contact null
DELETE /data/crm_account/ID, the accepted quote under that account	409, same sentence	200. The account, contact and quote are gone, because the quote is the account's master-detail child. "The quote survives" cannot apply to this shape (ruling item 4)
Live path: draft, in_review, presented, accepted through PATCH, then the drafted contract given another primary contact	409 "… 1 active quote(s) …"	200. The quote stays accepted with contact null
CONTROL: a presented quote, direct and account delete	409	409 DELETE_RESTRICTED, nothing moves
Rejected or expired quote	200	200 (unchanged)

PM assumption 1 held on next.5, and so did assumption 2: a presented quote still blocks, and blanking its contact is still refused (the quote-contact-required-when enforcement pins are green).

One new reading on the live path. With the contract still naming the contact, the delete is now refused by the engine itself: "This Contact is still referenced by 1 Contract record(s) through “Primary Contact”, which is required and cannot be cleared." That is the contract rule #2019 documents.

Stop condition: the console form and previous (ruling item 6)

Headless Chromium at /opt/pw-browsers/chromium, 1440×900, pnpm dev, a fresh database, signed in as sales.manager@objectos.ai (from pnpm demo:staff). It was measured on the probe diff, then again on the final head 19cf6f0b.

Quote	Edit Quote dialog, Contact field	Result
Accepted (QTE-0002)	label Contact, no required marker, lookup trigger without aria-required	Removing the contact and clicking Update sends PATCH /api/v1/data/crm_quote/ID {"crm_contact":null}. It answers 200 ("Quote updated successfully"), and the stored row is accepted with contact null
Presented (control)	Contact* with the required marker, trigger aria-required="true"	unchanged
Draft (control)	Contact, not required	unchanged

No [object-ui] A conditional predicate failed to evaluate warning was logged. The form binds the persisted row as previous in edit mode. The stop condition did not trigger: the form shows the contact as optional on an accepted quote, and it does not refuse the save the server allows.

That save also shows the trade the ruling accepted. A user can now clear an accepted quote's contact by hand, because quote_workflow's #720 yield admits any caller's link clear.

Tests and gates (final head 19cf6f0b)

• pnpm verify, split as the dispatch asks, each through os-verify-lock.sh:
  • build half: validate, typecheck, lint, lint:i18n-gate, hygiene, hygiene:tokens and build, each exit 0, VERDICT command-exit 0;
  • vitest run --shard=1/3: Test Files 66 passed (66), Tests 1094 passed (1094), VERDICT batch-last-exit 0 (the shard command was the last part);
  • vitest run --shard=2/3: 66 passed, Tests 1244 passed | 1 skipped (1245), VERDICT command-exit 0;
  • vitest run --shard=3/3: 66 passed, Tests 1590 passed (1590), VERDICT command-exit 0.
  • 198 test files ran, which is the number on disk.
• New test/accepted-quote-frees-contact.test.ts (8 tests, REST door, sales manager), each pin naming its shape:
  • direct delete;
  • account delete with the quote on another account;
  • account delete with the quote under the deleted account (deleted with it);
  • presented-quote control on both doors;
  • the sentence's plurals and remedies;
  • the gate: accepting a presented quote while clearing its contact is refused; a quote born accepted with no contact is refused.
  • Refusals are asserted by envelope (code + status, and fields[] = crm_contact:required).
• Pins rewritten by the sentence change: test/cascade-guard-messages.test.ts (2 assertions) and test/hooks-runtime-sales.test.ts (2 assertions). In test/quote-contact-required-when.test.ts only the source-text assertion changed; every enforcement pin is unchanged and green.
• Ablations, each through scripts/ablation-replace.mjs (anchor hit, blob change and restore proven on disk), run against the new pin file:
  • A1, the old predicate back: 2 failed | 6 passed. Red: direct delete and account delete (quote elsewhere).
  • A2, the count keeps accepted: 3 failed | 5 passed. Red: all three delete shapes.
  • A3, previous == null || dropped: stayed green, 8 passed. On next.5, has() on a null previous also answers false, so the two guards overlap on an insert. The explicit term is kept as ruled; the comment records the reading.
  • A4, the plural shape back (opportunity(ies)): 1 failed | 7 passed. Red: the sentence test.
  • After all four legs, both files' blobs equal HEAD and git diff HEAD is 0 bytes.
• CI runs the rest.

Deviations

• File surface. The claim's surface did not name three files, and the change needed them:
  • test/hooks-runtime-sales.test.ts pins the old refusal sentence verbatim (two assertions), and the ruled sentence rewrite turns them red.
  • src/sales/translations/en/objects.commerce.ts and src/sales/translations/zh-CN/objects.commerce.ts carry the Contact help text, which read as an invariant once the rule became a gate. The description line beside the predicate changed for the same reason.
  • Each edit is one line or two assertions.

Acceptance notes

• The test/quote-contact-required-when.test.ts header still says a predicate that cannot evaluate is "SKIPPED with a warning". That has been stale since 17.0.0-rc.2. It was left alone because the dispatch limited that file to the source-text assertion. Carrier: none.
• content/docs/sales/quotes.zh-Hans.mdx and .zh-Hant.mdx have never carried the English page's "A quote cannot be Presented or Accepted without a contact" bullet or its admin tip on the Contact requirement. That is pre-existing drift, not added here. Carrier: none.
• test/quote-line-freeze.test.ts records a dated next.3 reading: an account delete with an accepted quote was refused by contact_integrity, so its account case uses an expired quote. The reading stays true as dated; an accepted case is now reachable. Carrier: none.
• On the live path the account delete as the sales manager answers 403, because the drafted contract is a master-detail child the manager may not delete (crm_contract.allowDelete: false, Sharing coverage gap: territory/team-shared accounts show quote, task and contract related lists the rep cannot read #549). This is existing design and outside this card.
• In the browser, the accepted quote's Edit Quote dialog showed Quote Owner empty ("Select…") for the sales manager. Not investigated; noted only.

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
hotcrm	Ignored		Oct 19, 2026 2:49pm UTC

[objectstack-fleet]

席位核对

ACCEPT (#2161, the maintainer's ruling A 6267342596, p2) · PR #2183 at 19cf6f0baa · repo:hotcrm seat · os-project-manager · session session_01BDgipbNowaGa139em8Fhoq · 2026-10-19T14:54Z · report on hotcrm#2161 (6270122953); surface amended at review (6270189500)

1. Shape:
   • Draft, opening with Fixes #2161 and Clause-②: no. Assignee os-project-manager.
   • 15 files, +360 / −41. No governed path.
   • 0 model-identifier lines in the commits. The only closing keyword is Fixes #2161.
   • The head contains main f8eed90d, which is main's tip (fix(dashboards): Pipeline by Stage is a horizontal bar chart, not a funnel (#2073 item 2) #2182 merged in, dashboards only).
2. Premise, re-measured on next.5 (0336ad00, REST as a sales manager): an accepted quote gives a 409 on the direct delete and on both account-delete shapes, and on the live path. Rejected and expired answer 200.
3. The diff, read, against the ruling's items:
   • Item 1: crm_quote.crm_contact's requiredWhen is the ruled predicate, verbatim. Its comment block states the gate, why 冻结/锁定守卫会拒绝引擎的引用清理:被冻结的记录让它引用的人和客户永远删不掉 #720 and crm_quote.crm_contact 要不要自 presented 起 requiredWhen——缺 contact 的报价永远起草不出合同,失败只出现在服务器日志里(源自 #714) #1017 both hold, and a corrected platform fact: an unevaluable predicate is rejected since rc.2, not skipped.
   • Item 2: contact_integrity excludes accepted, rejected and expired.
   • Item 3: the refusal lists only what holds the contact, with real plurals and no zero counts, and only remedies that free it. For an open quote that is another contact or a rejection. Acceptance is not offered: it would draft a contract naming the same person.
   • Item 4: test/accepted-quote-frees-contact.test.ts pins the direct delete, both account-delete shapes, the live path and the presented control, and says which shape keeps the quote.
   • Item 5: the riders are all present:
     • the plurals (Browser pass #2058 — HotCRM-side defects (18 items: accepted quote still takes lines, half-converted leads, agents losing their cases, unreachable Sales Home, …) — list card, split per item at dispatch #2060 item 12's contact half);
     • the "no cascade marker" note now names ctx.referentialCascadeDelete (objectstack#23221);
     • import-and-export "Data deletion requests" and quotes, in all three locales.
   • Item 6, the stop condition, measured and not triggered: at 1440 as a sales manager, an accepted quote's Edit Quote dialog shows Contact without a required marker. Clearing it saves with PATCH 200, and no predicate-fault warning appears. The controls hold: Presented shows Contact* with aria-required, and draft is not required.
4. Accepted deviation: three files outside the named surface. Recorded on the card at review (6270189500, the adjacency check passes on all four conditions):
   • test/hooks-runtime-sales.test.ts, the old sentence pin;
   • the en and zh-CN Contact help text, which stated an invariant this change makes false;
   • the description beside the predicate.
5. Gates:
   • pnpm verify on 19cf6f0b through the lock: the build half exits 0, and the shards (66 + 66 + 66 files) exit 0 / 0 / 0.
   • Ablations on the committed head, each proven restored:
     • the old predicate turns 2 pins red;
     • the old count turns 3 red;
     • the old plural shape turns 1 red;
     • dropping previous == null stays green, because has() on a null previous answers false on next.5. The term is kept as ruled, and the comment records why.
   • CI on 19cf6f0b: 9 of 10 success. Build and Test (22.x) was running at review time.
6. Changeset, read: a patch written for an admin handling a data-deletion request. Each claim matches the measurement:
   • both deletes go through;
   • the accepted quote stays with its Contact cleared;
   • an accepted quote under the deleted account goes with the account;
   • the refusal names only open work, with real plurals;
   • the Contact rule still holds on the save into Presented or Accepted.
7. Out of scope: none reported. pnpm demo:staff straight after a fresh boot races the background seed: pre-existing, already recorded on PR chore(deps): upgrade the ObjectStack platform to 18.0.0-next.5 #2181 → Acceptance notes.
8. Landing: ready plus auto-merge once every check on this head reads success and the head still contains main's tip.