Skip to content

fix(portal): lock profile-managed run resources - #1632

Merged
Cedric Vidal (cedricvidal) merged 4 commits into
cedricvidal-fix-multi-profile-submissionfrom
cedricvidal-lock-profile-resources
Nov 5, 2026
Merged

Cedric Vidal (cedricvidal) merged 4 commits into
cedricvidal-fix-multi-profile-submissionfrom
cedricvidal-lock-profile-resources

Conversation

@cedricvidal

@cedricvidal Cedric Vidal (cedricvidal) commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • move Resources into the /runs/new agent/runtime integration area beside MCP Servers and Skills
  • lock profile-managed resource bindings, revisions, and preset parameter values while preserving editable parameter gaps allowed by the single-profile API contract
  • keep resources fully editable when the selected profile does not declare resource bindings
  • add focused regression coverage, ResourcePicker Storybook states, and architecture documentation

Relates to #1626.

PR stack

  1. fix: isolate profile variation submissions #1631 — Profile variation isolation
  2. fix(portal): lock profile-managed run resources #1632 — Profile-managed Resources UI (this PR)

This PR targets #1631's upstream branch, cedricvidal-fix-multi-profile-submission; #1631 must merge first.

Demos

Before

N/A — no recording attached.

After

Headless walkthrough showing resource placement, profile-managed locks, editable run-owned parameter gaps, and profiles without resource bindings:

profile-managed-resources.mp4

Testing

  • Passed: pnpm exec vitest run apps/portal/src/pages/SubmitRun.variations.test.tsx apps/portal/src/components/ResourcePicker.test.tsx --reporter=default (2 files, 4 tests)
  • Passed: pnpm --filter portal build
  • Passed: pnpm --filter portal build-storybook --quiet
  • Passed: authenticated Playwright smoke test against the Compose stack covering runtime placement, profile-owned binding/revision/preset locks, editable run-owned parameter gaps, and profiles without resource bindings
  • Passed: headless 1440×900 walkthrough playback verification (H.264, yuv420p, 25.44 seconds)

Documentation and compatibility

  • Updated docs/architecture/resources.md with the run-wizard location and profile/run ownership behavior.
  • No API contract, CLI behavior, database schema, migration, dependency, or upgrade changes.

Checklist

  • If Portal features changed, keep CLI capabilities in sync. (N/A — this UI enforcement reflects the existing API/CLI contract.)
  • If Portal components changed, update their Storybook stories.
  • If database changes require a migration, include up() / down() and keep it CosmosDB-compatible. (N/A — no database changes.)
  • If dependencies changed, update the lockfile and regenerate NOTICE / NOTICE-REVIEW.txt with pnpm notice as needed. (N/A — no dependency changes.)
  • Video showing the behavior before the suggested change
  • Video showing the behavior after the suggested change

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added type: documentation Documentation additions, corrections, and improvements. language: javascript Work involving JavaScript code, tooling, or dependencies. area: portal Scope web portal, pages, and user-facing components. topic: testing Test coverage, test infrastructure, and validation quality. topic: ui Portal, visual presentation, layout, and interface components. labels Nov 5, 2026
@cedricvidal
Cedric Vidal (cedricvidal) marked this pull request as ready for review November 5, 2026 04:09
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Test Results (Node.js 22)

test: Run #524

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
3267 3267 0 0 0 0 0 1m35s

🎉 All tests passed!

Github Test Reporter

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Test Results (Node.js 22)

test: Run #527

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
3305 3305 0 0 0 0 0 1m34s

🎉 All tests passed!

Github Test Reporter

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Test Results (Node.js 22)

test: Run #529

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
3305 3305 0 0 0 0 0 1m33s

🎉 All tests passed!

Github Test Reporter

@cedricvidal
Cedric Vidal (cedricvidal) merged commit 92a9bae into main Nov 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: portal Scope web portal, pages, and user-facing components. language: javascript Work involving JavaScript code, tooling, or dependencies. topic: testing Test coverage, test infrastructure, and validation quality. topic: ui Portal, visual presentation, layout, and interface components. type: documentation Documentation additions, corrections, and improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants