Repository navigation
fix(portal): lock profile-managed run resources - #1629
Closed
Cedric Vidal (cedricvidal) wants to merge 3 commits into
Closed
Cedric Vidal (cedricvidal) wants to merge 3 commits into
Cedric Vidal (cedricvidal) wants to merge 3 commits into
Conversation
Move profile fan-out ownership into the API so every profile resolves against fresh shared run intent. Keep Portal and CLI payloads free of profile-managed fields and document the cross-client ownership invariant. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Superseded by the clean upstream stacked draft: #1632 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/runs/newagent/runtime integration area beside MCP Servers and SkillsRelates to #1626.
This PR depends on #1614. Because #1614 has not merged yet, this PR temporarily targets
mainwith the parent commits included in its diff. Once #1614 merges, the diff will reduce to only the profile-managed resource locking changes.Demos
Before
N/A — no recording attached.
After
Headless walkthrough showing resource placement, profile-managed locks, editable run-owned parameter gaps, and profiles without resource bindings:
profile-managed-resources.mp4
Testing
pnpm exec vitest run apps/portal/src/pages/SubmitRun.variations.test.tsx apps/portal/src/components/ResourcePicker.test.tsx --reporter=default(2 files, 4 tests)pnpm --filter portal buildpnpm --filter portal build-storybook --quietyuv420p, 25.44 seconds)Documentation and compatibility
docs/architecture/resources.mdwith the run-wizard location and profile/run ownership behavior.Checklist
up()/down()and keep it CosmosDB-compatible. (N/A — no database changes.)NOTICE/NOTICE-REVIEW.txtwithpnpm noticeas needed. (N/A — no dependency changes.)