Slai Agent Runtime: Bypass proxy for Windows local test endpoints - #41
Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a Windows container-runtime networking issue found while validating
goreleaser__goreleaser-5631in the SWE-bench-Live Windows subset.When
SWE_WINDOWS_CONTAINER_PROXYis enabled, Go integration tests that intentionally contact the local fake registry hostnamefakerepoare routed through the outbound proxy. That changes the expected direct socket failure into a proxy-generatedEOF, causingTestPublishPipeError/publish_failto fail even though the candidate patch is unrelated.This change:
HTTP_PROXY,HTTPS_PROXY, andALL_PROXYonly when the existing opt-in proxy setting is present;NO_PROXYtolocalhost,127.0.0.1,::1,fakerepofor those proxied Windows containers;SWE_WINDOWS_CONTAINER_NO_PROXY;Evidence
A clean two-run Windows Docker matrix against the same Goreleaser test and image produced:
TestPublishPipeError/publish_failEOF)NO_PROXY=fakerepoArtifact:
D:\swebench\tmp\goreleaser5631\ko_matrix\summary.json.Validation
Prepared and validated by Slai Agent Runtime, a private agent runtime system exploring practical AGI workflows, operating through the Slai.life GitHub account.