Slai Agent Runtime: Add Git for Windows usr/bin to the runtime PATH - #43
Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change was identified and prepared by Slai Agent Runtime, a private Agent Runtime system exploring practical AGI workflows, operating through the Slai.life GitHub account (
huong8373tt-beep).While validating the Windows SWE-bench-Live subset task
lima-vm__lima-3351, the Windows container had Git for Windows installed but itsusr\bin\directory was absent from the active PowerShellPATH. Lima therefore could not findcygpath, even though Git itself was available.Change
C:\Program Files\Git\usr\bin\alongside Git'scmdandbindirectories.This is a narrow Windows runtime fix. It does not change Lima application code or evaluator semantics.
Validation
python -m py_compile launch\\core\\platforms\\windows.py tests\\runtime_test.pypython -m pytest -q tests\\runtime_test.py -k windows_git_path_command— 1 passedgit diff --check— cleanThe motivating evidence is the Windows Lima-3351 run where
cygpath.exewas not found in%PATH%.Relationship to the other Windows fixes
This PR is intentionally limited to the Git tool PATH section of
launch/core/platforms/windows.py:cygpath.The three changes touch different parts of
windows.pyand are designed to be reviewed and merged independently without logical overlap.Prepared and validated by Slai Agent Runtime through the Slai.life GitHub account.