Repository navigation
refactor(arch): remove slop from the package-by-module and CW1004 work - #1128
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1087
Refs #1116
Removes dead code and stale prose that the package-by-module work (#1089–#1099, #1119) and the CW1004 work (#1116) left behind. It also carries the credential-epoch sentence from #1127, which is closed in favour of this PR. Behaviour does not change.
What changed and why
ModuleEdgeAnalyzer.Attribute,ModuleMap.ClaimantClaimantis deleted_claimsholds only namespaces.Claimant(symbol)could match only a type whose full name equals a claimed namespace, and no type insrc/does (all 904 type names checked against all 35 claims)tools/module-move/move.pymarkscommand deleted[ModuleContract], which #1099 deleted; nothing is left to stripCommon/Architecture/Modules/*.csDomain.Accounts.*,Domain.Catalog.EggUnitandDomain.Eggs.EggLotbecome "Farm's X", "Commerce's EggUnit" and "EggLot"src/AGENTS.md, decisions 514, 850 and 1023AccessOwnershipClaimTestscommentsrc/AGENTS.md, contract ruleContracts/foldersrc/AGENTS.md, ledger ruledocs/architecture.md, epoch sentence (from #1127)/errorre-execution as exempt, and the unparseable-claim rejectionCredentialEpochFreshReadTestspins the exemptionsConsidered and left unchanged:
AdapterScope's twoConcathelpers. The owner chose a single shared definition in feat(arch): CW1004, flag non-contract peer reach inside method bodies #1116.Proof
dotnet build Cluckwork.slnx --no-incrementalCreateExpenseHandlernames Commerce'sDiscountCeilingerror CW1001: undeclared cross-owner edge Finance -> CommerceCreateExpenseHandlernames Flock Management'sFlockerror CW1004: Finance … reaches FlockManagement's non-contract type …Flockmove.py marksGuard classes, each run on its own:
ModuleEdgeAnalyzerTests14,ModuleLedgerRealTreeTests2,ModuleLedgerTests41,AdapterReachRealTreeTests2,AdapterReachTests102,PeerContractRealTreeTests1,PeerContractTests10,AdapterTierRealTreeTests3,CompatibilityExceptionRealTreeTests2,CompatibilityExceptionTests37,ContractDerivationTests1,ModuleContractRealAssemblyTests1,NamespaceFolderAgreementTests10,AccessOwnershipClaimTests2,SeamSurfaceRealAssemblyTests2,CouplingMatrixRealTreeTests3,TableOwnerRealModelTests2,TenantBypassRealTreeTests4 andTenancyDocsFreshnessTests1 all pass. TheSchemaDocsTestsimage-pin guards andCredentialEpochFreshReadTestspass 11/11 together.