Repository navigation
Conversation
Owner
Author
|
Folded into #1128 at the owner's request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/architecture.mdsaid the credential-epoch check reads the database on every authenticated request.CredentialEpochMiddlewareskips two kinds of request:/api/v1/auth/logout, with or without a trailing slash, and the/errorre-execution, which it detects throughIExceptionHandlerFeature. The sentence now names both. It also says that a token whose user or account claim does not parse is rejected without a database read.CredentialEpochFreshReadTests.EveryAuthenticatedRequest_ReadsTheCredentialRowOnce_AndOnlyLogoutIsExemptpins this behaviour.This is a review finding (P3) on #1126 that arrived after #1126 merged.
Checks at the head:
CouplingMatrixRealTreeTestsandTenancyDocsFreshnessTestspass 4/4. TheSchemaDocsTestsimage-pin guards andCredentialEpochFreshReadTestspass 11/11 together.