Repository navigation
[SPT-1668] Don't split comma-separated str values for *_any_of params - #1037
Merged
Merged
Conversation
_get_params joined every *_any_of value with ",".join(val), which assumes a list. The spec defines every any_of param as a comma-separated string, and most methods type them as Optional[str], so passing e.g. ticker_any_of="AAPL,VZ" sent ticker.any_of=A,A,P,L,,,V,Z and silently returned data for the wrong tickers. Only join non-str iterables. Lists, tuples, etc. behave as before.
justinpolygon
marked this pull request as ready for review
October 16, 2026 19:27
justinpolygon
requested review from
jbonzo,
kschoche,
lukeoleson,
mmoghaddam385 and
suever
as code owners
October 16, 2026 19:28
lukeoleson
approved these changes
Oct 16, 2026
lukeoleson
reviewed
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a comma-separated string to any
*_any_ofargument, e.g.ticker_any_of="AAPL,VZ", split it into characters (A,A,P,L,,,V,Z) and silently returned the wrong data._get_paramsnow passes strings through unchanged and only joins lists. Lists work as before, so this isn't a breaking change.Tests cover the string and list forms. SPT-1668