Repository navigation
[SPT-1407] Add last_updated/timeframe to IndicesSnapshot and list_snapshot_indices - #1038
Merged
Merged
Conversation
…pshot_indices IndicesSnapshot was missing last_updated and timeframe, which the API returns and the spec defines. They're appended after the existing fields so positional construction is unchanged. get_snapshot_indices uses _get, so it only ever returns the first page (250 of ~13.5k indices) and only accepts ticker_any_of. Add list_snapshot_indices, which uses _paginate to follow next_url and takes the spec's ticker, ticker range, order, limit and sort params. get_snapshot_indices keeps its signature and List return type.
justinpolygon
marked this pull request as ready for review
October 16, 2026 19:27
justinpolygon
requested review from
jbonzo,
kschoche,
lukeoleson,
mmoghaddam385 and
suever
as code owners
October 16, 2026 19:27
lukeoleson
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
last_updatedandtimeframetoIndicesSnapshot. The API returns them, but the model was missing them.list_snapshot_indices, which paginates.get_snapshot_indicesonly ever returns the first page (250 indices) and is unchanged.No breaking changes. Tests, docs and an example are included.