Repository navigation
Harden local image reading - #75
Merged
Merged
Conversation
Only files with an allowlisted image extension are opened, so a reference such as ../../.ssh/id_rsa is no longer embedded. Symlinks are resolved before the path check, so a link cannot reach outside the allowed area. The parent-directory check now uses filepath.Rel instead of a string prefix, which also removes the sibling-directory prefix match. Only regular files are read, and the size cap applies while reading, not only to the stat result. The 3-level parent allowance stays, because markdown repos often keep images in a sibling directory. Content sniffing for unknown extensions is gone: extensionless images are no longer embedded. Closes #66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filepath.Rel(fixes thedocsvsdocs-secretprefix match)...allowance stays, so images in a sibling directory still work.CLAUDE.md.Tests cover traversal limits, symlinks, non-image files, directories and the size cap.
Closes #66