Repository navigation
Clean up main.go and extend test coverage - #78
Merged
Merged
Conversation
Format main.go with gofmt. Build the Snap temp path with filepath.Join. Print log warnings without a timestamp and with the mdview prefix, to match the messages from check(). The html parameter shadowing and the per-call regex compile from the issue were already fixed in the image embedding rewrite. Add tests for getTitleFromAST, isRelativePath and tempFileName. The traversal limits, size cap, HTML img handling, embedMermaidScript and getTempDir are covered by earlier changes. Closes #69
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gofmtonmain.go.filepath.Join.mdview:prefix, matchingcheck().getTitleFromAST,isRelativePathandtempFileName.Already done by earlier PRs: the
htmlparameter shadowing and the per-call regex compile (#74), and tests for traversal limits, the size cap, HTML<img>handling (#74, #75),embedMermaidScriptandgetTempDir(#77).Closes #69