P3-19..P3-23: lite build, viewer sizing, carousel, diagram toggle - #134
Merged
Merged
Conversation
Set integrations/herdr/herdr-plugin.toml to 0.1.4 and add it to the release-prepare checklist in releasing.md. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
P3-19: new wiki-reader-media crate (palette and fit maths always built; decode and Mermaid/SVG raster behind `raster`), a default-on `media` feature forwarded render -> binary, ADR-0023 (proposed), RenderedDoc::media inventory, check.sh [all|default|lite] and CI for both builds with a lite dependency-tree assertion, lite install docs and benchmarks. P3-20: content-sized modal panels, fit/actual (a), styled table cells. P3-21: Tab/Shift+Tab carousel over the media inventory. P3-22: v cycles image/text/source for the open diagram. The lite and viewer changes share render.rs, images.rs and the viewer modules, so they land together. scripts/check.sh is green for default and lite. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Record the single-release decision, keep P3-19..P3-23 at `doing` and the phase `active` until review and dogfood, restore the compact dogfood-log table, and note the operator-gated PNG retake. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on the manifest-bump PR; GitHub retargets it to
mainonce that merges.wiki-reader-mediacrate (palette and fit maths always built; decode and Mermaid/SVG raster behindraster), a default-onmediafeature forwarded render → binary, andRenderedDoc::media, a tier-independent media inventory.cargo install --no-default-featuresdropsimage,resvg,mermaid-rs-rendererandratatui-image(binary 16.6 → 8.4 MiB, clean build ≈ 50.7 → 19.9 s; seewiki/architecture/benchmarks.md).diagrams = imagefalls back to text with a reason, and the Images options group is hidden.scripts/check.sh [all|default|lite]now takes arguments; CI runs lite clippy and tests and asserts the lite dependency tree excludes the four heavy crates.-literelease artifact.a), styled table cells (DocCell).vcycles image / text / source for the open diagram (session-only).Lite and the viewers share
render.rs,images.rsand the viewer modules, so they are one commit by design. Per the release-shape decision they ship together as v0.1.5. P3-19 to P3-23 staydoingand ADR-0023 staysproposeduntil review and a manual Ghostty/herdr pass.Test plan
./scripts/check.sh(default and lite): exit 0, no failures or warnings.fixtures/images,fixtures/mermaid,wiki/(table viewer,a, zoom, Tab/Shift+Tab,v, litediagrams = imagefallback).assets/wiki-reader.pngand thewiki/assets/copies.🤖 Generated with Claude Code