Skip to content

fix: failed diagram modal size and table viewer readability (P3-20, P3-21) - #135

Closed
dvzrd wants to merge 2 commits into
mainfrom
fix/viewer-failed-diagram-and-table
Closed

dvzrd wants to merge 2 commits into
mainfrom
fix/viewer-failed-diagram-and-table

Conversation

@dvzrd

@dvzrd dvzrd commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Dogfood fixes after #134.

  • Failed diagram modal: a failed graphics render no longer asks for the whole screen. ImageViewer::want sizes the panel to the error line plus the source, and scroll_text is bounded by the displayed lines.
  • Table viewer: columns use their natural width with horizontal scroll (no 40-column cut), the last column fills the window with no dangling │, and a ─┼─ rule sits under the header.

Test plan

  • ./scripts/check.sh (default and lite) green on the top of the stack, whose tree matches this branch plus the later PRs.
  • New tests: failed-render size, filled last column, a 60-character cell shown in full, header rule ┼.
  • Operator: Mermaid bad opens small; table viewer on wiki/architecture/prior-art-and-libs.md and the roadmap tables.

Stack: this PR → #136 (status enum) → #137 (toolbar icons) → #138 (code viewer). Merge in order; each later PR is rebased onto main after the one below it is squash-merged.

🤖 Generated with Claude Code

dvzrd and others added 2 commits October 4, 2026 13:28
Failed graphics returned the full screen cap from want, so a bad Mermaid
opened full-screen. Size to the error note plus source, scroll that text,
and make the table viewer use natural widths, a header rule, and a filled
last column.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@dvzrd

dvzrd commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

Landed on main as part of #138 (squash commit aab5f32). #138 was retargeted to main by mistake while merging the stack in order, so its squash carried this PR's commits too. main's tree is identical to the stack tip that ./scripts/check.sh and CI passed on, so nothing is missing. Closing as merged-via-#138.

@dvzrd dvzrd closed this Oct 4, 2026
@dvzrd
dvzrd deleted the fix/viewer-failed-diagram-and-table branch October 6, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant