P3-10: publish the current page to herdr's sidebar - #130
Merged
Merged
Conversation
Inside a herdr pane with its own HERDR_PANE_ID, a worker thread sends the page title and a `page` token with `herdr pane report-metadata`: - debounced (250 ms), 10 min TTL renewed every 4 min, cleared on exit; - --seq is Unix time in ms, strictly increasing, so a restarted reader is not ignored as stale; - values pass as --name=value (a title starting with `-` is safe), control characters stripped, text capped at herdr's 80 characters; - never reports agent state; a missing binary or failing call never touches navigation and stops after three failures in a row; - plugin popups (no pane id) and tests never publish: the publisher is only created by `run`. `[herdr] publish` (default true) turns it off. ADR-0022 records this and the ordinary-pane launcher. Docs, roadmap and dogfood log updated. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
dvzrd
force-pushed
the
feat/p3-10-herdr-metadata
branch
from
October 4, 2026 02:50
8b803f8 to
12fb14a
Compare
herdr's CLI rejects `--title=value` ("unknown option"), so every report from
the first operator run failed and the publisher went quiet after three
failures. Pass `--title T --token page=P` as separate arguments; herdr accepts
a value that starts with `-` that way.
The fake herdr in the unit tests could not catch this, so add an opt-in test
against the real CLI (WIKI_READER_TEST_HERDR_PANE=<idle pane>, --ignored):
publish, read back with `pane get`, clear on drop. A unit test also asserts no
argument uses the `--name=value` form.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inside a herdr pane with its own
HERDR_PANE_ID, wiki-reader publishes the page being read to herdr's sidebar as display-only pane metadata, on by default ([herdr] publish = falseto opt out, as decided).Publisherworker thread incrates/wiki-reader/src/herdr.rsrunsherdr pane report-metadatawith a title and apagetoken. No socket client, no new dependency.--seqis Unix time in ms and strictly increasing, so a restarted reader is not ignored as stale.--title=…/--token=page=…, control characters stripped, text capped at herdr's 80 characters (long paths keep their tail).run, so tests running inside herdr cannot publish to a real pane.App::sync_herdrhands over page changes from the event loop.#128 and #129 are merged; this branch is a single commit on top of
main.Verification
scripts/check.shpassed.🤖 Generated with Claude Code