Repository navigation
Move RunnerOptions and related types to the API - #4822
Merged
Merged
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Assisted-by: Cursor:grok-4.7 Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Assisted-by: Cursor:grok-4.7 Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
mozesl-nokia
force-pushed
the
move-runneropts
branch
from
October 26, 2026 10:00
1b57cdd to
5acfe4c
Compare
mozesl-nokia
marked this pull request as ready for review
October 26, 2026 10:01
mozesl-nokia
requested review from
efiacor,
kispaljr and
liamfallon
as code owners
October 26, 2026 10:01
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The root and CLI modules still select an API release without the moved packages and types, blocking builds outside a local API workspace.
1 open issue
What changed in this PR
This PR moves shared function-runner types into the separately versioned API module, building on the CLI-module extraction in #4811. It keeps CLI flag handling and CEL implementation outside the API.
Changes:
- Moves runner options, image-pull constants, formatting utilities, and execution errors into the API.
- Introduces a condition-evaluator interface and a CLI image-pull-policy adapter.
- Updates consumers and reorganizes tests around the new package boundaries.
| File | Description |
|---|---|
| README.md | Documents runner options in the API module. |
| pkg/lib/util/get/get.go | Uses API options and extracted CEL initialization. |
| pkg/lib/runneroptions/imagepullpolicy.go | Removes the old policy implementation. |
| pkg/lib/kptops/render.go | Imports API runner options. |
| pkg/lib/kptops/render_executor.go | Uses API options and execution errors. |
| pkg/lib/kptops/render_executor_util_test.go | Updates the options import. |
| pkg/lib/kptops/render_executor_test.go | Updates the options import. |
| pkg/lib/kptops/hook_executor.go | Imports API runner options. |
| pkg/lib/kptops/fs_test.go | Updates options and CEL initialization. |
| pkg/lib/kptops/configref_test.go | Updates the options import. |
| pkg/lib/celenv/celenv.go | Separates CEL implementation from API types. |
| pkg/lib/celenv/celenv_test.go | Moves tests into the CEL package. |
| pkg/fn/runtime/runner.go | Uses API types and the evaluator interface. |
| pkg/fn/runtime/runner_test.go | Updates options and formatter references. |
| pkg/fn/runtime/imagepullpolicy.go | Removes the duplicate policy implementation. |
| pkg/fn/runtime/exec.go | Returns the API execution-error type. |
| pkg/fn/runtime/container.go | Uses API options and execution errors. |
| pkg/fn/runtime/container_test.go | Receives Docker output-filter tests. |
| pkg/fn/runtime/condition_test.go | Uses the extracted CEL package. |
| pkg/fn/runtime/celeval_test.go | Updates CEL test helpers. |
| cli/fn/render/cmdrender.go | Wires the policy adapter and CEL initializer. |
| cli/fn/imagepullpolicy/imagepullpolicy.go | Adds the CLI-specific flag adapter. |
| cli/fn/doc/cmdfndoc.go | Imports API runner options. |
| cli/fn/cmdeval/runfn.go | Imports API runner options. |
| cli/fn/cmdeval/cmdeval.go | Wires the policy adapter and CEL initializer. |
| cli/fn/cmdeval/cmdeval_test.go | Updates the options import. |
| api/utils/single_line_formatter.go | Houses the shared output formatter. |
| api/runneroptions/runneroptions.go | Houses options and defines the evaluator interface. |
| api/runneroptions/runneroptions_test.go | Adds API-level option tests. |
| api/runneroptions/imagepullpolicy.go | Defines shared image-pull-policy constants. |
| api/fnresult/v1/errors.go | Houses the execution-error type. |
| api/fnresult/v1/errors_test.go | Keeps error tests separate from runtime tests. |
Review effort: Balanced
|
liamfallon
approved these changes
Oct 27, 2026
efiacor
approved these changes
Oct 27, 2026
Nikshay1
added a commit
to Nikshay1/kpt
that referenced
this pull request
Oct 27, 2026
kptdev#4822 moved ExecError to api/fnresult/v1 and RunnerOptions to api/runneroptions. The rebase carried the Timeout and RunTimeout fields of ExecError over to the new package. timeoutMessage is exported as TimeoutMessage, because the runtime now calls it from another package. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Nikshay <nikshayyadav90@gmail.com>
efiacor
pushed a commit
that referenced
this pull request
Oct 27, 2026
Nikshay1
added a commit
to Nikshay1/kpt
that referenced
this pull request
Oct 28, 2026
kptdev#4822 moved ExecError to api/fnresult/v1 and RunnerOptions to api/runneroptions. The rebase carried the Timeout and RunTimeout fields of ExecError over to the new package. timeoutMessage is exported as TimeoutMessage, because the runtime now calls it from another package. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Nikshay <nikshayyadav90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the following types to the API module:
RunnerOptionsSingleLineFormatterImagePullPolicyconstsExecErrorHad to do some refactoring around ImagePullPolicy and CEL env as well.
Depends on #4811 (and currently includes the commits from that branch as well)
AI disclosure: