Repository navigation
Fix the build of the exec function tests on Unix - #4831
Merged
Merged
Conversation
kptdev#4822 moved ExecError to the fnresult API package, and kptdev#4800 added exec_unix_test.go, which still uses runtime.ExecError. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Nikshay <nikshayyadav90@gmail.com>
Nikshay1
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
October 27, 2026 15:20
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single-line correction matches the runtime’s returned error type and resolves the test compilation failure without changing behavior.
No open issues 🎉
What changed in this PR
Fixes the Unix exec-function test build failure caused by the relocation of ExecError to the API module in #4822.
Changes:
- Uses
fnresultv1.ExecErrorin the timeout test, preserving existing assertions and leaving production behavior unchanged.
| File | Description |
|---|---|
pkg/fn/runtime/exec_unix_test.go |
Qualifies the error type with its API package using the existing import. |
Review effort: Balanced
mozesl-nokia
approved these changes
Oct 27, 2026
|
efiacor
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On current main, the
pkg/fn/runtimetests don't build on Linux and macOS:#4800 added
exec_unix_test.go, which usesExecErrorfrompkg/fn/runtime. Around the same time, #4822 movedExecErrortoapi/fnresult/v1. Each PR was green on its own. This PR changes that one reference tofnresultv1.ExecError. The import is already there.Motivation
Any PR that changes code and is rebased onto main would fail
build-test-dockerandbuild-test-podmanon this. The test is mine from #4800, so I wanted to fix it before it trips someone else. I think it went unnoticed because the Go workflow hasn't run on a push to main since 2025-09-10. I can open an issue about that if it's useful.Testing
go vet ./pkg/fn/runtime/andgo test ./pkg/fn/runtime/pass on this branch. On main, the package fails to build.AI usage
I have used AI in the creation of this PR.
I have used the following AI tools: