Repository navigation
ci: adopt audited book-formatter SHA - #260
Conversation
|
@codex review Exact head |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🔵 Needs a closer look
Correctness hinges on the external book-formatter commit's existence and audited state, which cannot be verified from this repository and warrants human confirmation.
0 open findings
What changed in this PR
This PR updates the pinned commit SHA used to check out the itdojp/book-formatter repository within the Book QA GitHub Actions workflow. It moves the pin from the previous audited commit (cff9fcf8...) to a newer audited commit (c4dcd01e..., corresponding to book-formatter PR #185), as part of the dependency-recovery work tracked in #259/#257. The change is intentionally minimal (a single line) and does not touch book content, docs/, runtime assets, consumer dependencies, Node/npm versions, or QA thresholds.
Changes:
- Updated the
ref:pin for thebook-formattercheckout step inbook-qa.ymlto the audited SHAc4dcd01e8450112f95002a454657d409cb3fa2f1.
| File | Description |
|---|---|
.github/workflows/book-qa.yml |
Bumps the pinned book-formatter checkout ref to the newer audited SHA; single-line change with correct YAML indentation. |
Verification notes: the old SHA no longer appears anywhere in the repository, the new SHA appears only in the expected location, and book-qa.yml is the only workflow that pins book-formatter by ref — so there are no stale references left to update. I could not independently confirm that the target SHA exists on the external book-formatter repo or that its audit status is as described, since that is outside this repository.
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
外部SHA / audit検証の補足とReady移行Copilot5529979217はCOMMENTED0 findingsですが、external SHA/監査を当該repo内から確認できないという制限を記載しています。人間APPROVEDと同一視せず、別途一次情報と実行結果を確認しました。
Ready自動reviewを確認してから通常matched-head merge/main検証へ進めます。人間承認の捏造・bypass・保護設定変更はしません。 |
概要
Refs #259 / portal itdojp/it-engineer-knowledge-architecture#297。#257 / PR258のroot依存修正・actualmain確認完了後、同repo直列の独立pin-only PR。
21d9ce24ae81224cde2176bbb8a28d6a3b751ddfc7dc7ab60c34cbc8383bc3f4af9d40bbfd8a6980.github/workflows/book-qa.ymlのref 1行のみcff9fcf8bae31140f07b358d314fc64173cb7013→ auditedc4dcd01e8450112f95002a454657d409cb3fa2f1本文/docs/assets/consumer依存/Node/npm/allowScripts/build/Pages/QA閾値は不変。formatterの共有assetsを配布するPRではなくQAチェックの固定SHA更新です。
検証
境界
既存layoutwarning2・mobile検索hidden/書名clipは同じです。pin-onlyで表示改善や全a11y対応を主張しません。root依存と限定YAML契約は前PR258でreview済み・本PRへ混在しません。no mutable main/tag, bypass, force/rebase/main push/settings/auto-merge。別担当white-hat/private内容は対象外。
完了証跡 — 独立QA pin更新
c7dc7ab60c34cbc8383bc3f4af9d40bbfd8a6980→ actual maine6b9f2c95ecab838a796c9e0933e23e6fec5de3c、reviewed/main tree一致、single parent。cff9fcf8bae31140f07b358d314fc64173cb7013→c4dcd01e8450112f95002a454657d409cb3fa2f1。root依存・限定YAML契約は先行deps: restore root audit gate before formatter rollout #257 / PR258で別処理。Review / CI
Actualmain / 公開検証
Cleanup / 全体