Disable backface culling by default for newton warp renderer - #6959
Open
huidongc wants to merge 1 commit into
Open
Disable backface culling by default for newton warp renderer#6959huidongc wants to merge 1 commit into
huidongc wants to merge 1 commit into
Conversation
Double-sided surfaces were being culled with the previous True default. Set enable_backface_culling=True to restore the old behavior.
huidongc
requested review from
AntoineRichard,
StafaH and
kellyguo11
as code owners
August 7, 2026 08:04
huidongc
marked this pull request as draft
August 7, 2026 08:05
Contributor
Greptile SummaryChanges the Newton Warp renderer’s default to preserve back-facing triangles while retaining an explicit opt-in for the previous culling behavior.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "Disable Newton Warp backface culling by ..." | Re-trigger Greptile |
pbarejko
reviewed
Aug 7, 2026
pbarejko
approved these changes
Aug 7, 2026
huidongc
marked this pull request as ready for review
August 7, 2026 22:49
Contributor
There was a problem hiding this comment.
Isaac Lab Review Bot
Reviewed the Newton Warp renderer’s backface-culling default change and its package changelog. The change makes double-sided surfaces visible by default while preserving explicit opt-in to the previous behavior.
- Design and architecture: The behavior remains isolated to
NewtonWarpRendererCfg; shared renderer infrastructure and backend selection are unchanged. This is an appropriate renderer-specific configuration decision. - API: The public field name and type remain stable, but its default behavior changes from enabled to disabled. The changelog clearly documents the compatibility surface and explains that setting
enable_backface_culling=Truerestores the prior behavior. - Implementation: The implementation is a direct default-value change, accompanied by a correctly located and formatted changelog fragment. The supplied benchmark indicates no clear throughput regression, with a modest observed GPU-memory increase remaining as a non-blocking tradeoff.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable backface culling by default for newton warp renderer. User can opt out if needed by setting
NewtonWarpRendererCfg.enable_backface_culling.Fixes OMPE-103486
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Dexsuite runtime benchmark
Performance and memory impact of disabling Newton Warp backface culling by default
(
NewtonWarpRendererCfg.enable_backface_culling: True → False).Comparison — before vs. after
Δ = after (
afc3ebd9) − before (50a244ec/ develop). Positive FPS Δ% means after is faster; negative GPU-mem / RAM Δ% means after uses less memory.Takeaways:
Before —
50a244ec70a(develop)Baseline with
enable_backface_culling=True(previous default).50a244ec70a Handle single-world coupled MPM resets (#6955)NewtonWarpRendererCfg.enable_backface_culling = Truehuidongc/benchmarks/20260807_newton_bfc_before_develop/After —
afc3ebd9(enable_backface_culling=False)Same benchmark after disabling backface culling by default.
afc3ebd9 Disable Newton Warp backface culling by defaultNewtonWarpRendererCfg.enable_backface_culling = Falsehuidongc/benchmarks/20260807_newton_bfc_after_7a64e7b/Setup
Isaac-Lift-KukaAllegro-Cameranewton_mjwarpnewton_rendererrgb64,single_camera,cube421000(after warmup)huidongc/benchmark_dexsuite.shChecklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there