feat: Drm - #24
Merged
Merged
feat: Drm#24
Conversation
The encrypted bytes now stay under the segment-job slot taken to read them, handed to the stream instead of a second slot, so resident encrypted segments are bounded by max_segment_jobs. The header region is streamed in stream_chunk_bytes pieces, so a client that stops reading an encrypted segment hits the idle timeout. The payload buffer is allocated once and the header is spliced in front of it instead of copying the payload. A failed encryption task counts as an encryption failure. Docs state the real bound: max_segment_jobs x max_segment_bytes.
RFC 8216 forbids two session keys with the same METHOD, URI, IV, KEYFORMAT and KEYFORMATVERSIONS, and KEYID does not tell them apart. Split keys repeated every system's line; each now appears once, for the first key. Identical split keys also count as one distinct key.
FairPlay's HLS key line carries no key ID, so a player could not ask for the audio key apart from the video one. validate() refuses the combination naming the field, and the mapper API and TDD 0009 examples now use one key for all tracks.
A 304 means nothing in the answer changed, encryption included, so a re-keyed asset must be answered with 200 and a new version. Also say that Widevine and PlayReady without a pssh are DASH-only, that large pssh boxes need a larger resolver.http.max_response_bytes, and that video encryption is H.264 for now.
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
How it was tested
Checklist
make cipassesgit commit -s)