feat(demo,admin): pick assets from a dropdown fed by an optional mapper listing - #19
Closed
includeamin wants to merge 2 commits into
Closed
includeamin wants to merge 2 commits into
includeamin wants to merge 2 commits into
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #18 (
clipping-and-concatenation). Merge #18 first; GitHub then retargets this PR tomain.What and why
With a mapper resolver, the demo and control panel could only offer assets that had already been played, because the server had no way to know the mapper's catalog. You had to know an asset's ID (such as the new
prerollandtrimmedexamples) and type it.GET /v1/assets: answers{"assets": [...]}./admin/statuspasses the list on asresolver.known_assets, asking concurrently with the health check.404, a malformed body or an outage just means no list (null), so existing mappers are unaffected.limits.max_assets. The response is size-bounded like any mapper answer.catalog.json./admin/statusnames, ending with "Custom…", which reveals a text field for any other ID (Enter plays it). It replaces the demo's "Try:" row and the control panel's separate picker plus text box.docs/operations.mdanddocs/usage.md.How it was tested
limits.max_assets. The existing test for a mapper without the endpoint still getsnull.prerollplays it past the clip boundary at 640×360. Choosing "Custom…" shows and focuses the name field, and typingtrimmed+ Enter requests and plays it.Checklist
make cipassesgit commit -s): not signed off. This is a branch in this repository, which the DCO check exempts.