Repository navigation
fix(npc): prepare IL2CPP client customer and dealer prefabs - #359
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 8, 2026
Closed
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An IL2CPP joining client reaches Customer.Awake without customerData and throws in Awake_UserLogic. Dealer conversion also leaves the donor NPC component attached: the baseline client registers two components on the same GameObject as the same dealer, producing five custom NPC entries instead of four.
Seed missing customer data on the inactive prefab using the same fallback defaults already used at runtime. Preserve existing donor data and explicit WithCustomerDefaults configuration. Remove the replaced dealer donor after rewiring, matching supplier conversion. This fixes the creation paths rather than hiding duplicate registry entries.
Fixes #357.
Validation
Compatibility
No public/protected signatures, parameter names, durable NPC IDs, save formats, or network payloads change. Fallback values are unchanged and shared between prefab preparation and runtime recovery. Non-null donor customer data is retained; explicit builder configuration still replaces it. Host authority, spawn/finalization order, and normal NPC animation are unchanged.