Repository navigation
fix(avatar): preserve fallback portrait pose and workbench animation - #358
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IL2CPP custom NPC portraits can disappear after returning to Menu and reloading. The fallback rig is cloned from a live avatar: its native Awake caches a transient hip position, and native Update restores that position after the clone has been rebound upright. A larger probe reproduced completely blank captures, with the head dropping from about 1.62 m to 0.80 m during the capture wait.
Keep gameplay animation initialization disabled on the owned fallback clone, rebind and freeze its Animator, then record the rebound hip position in the native saved-hip field. Native Update now retains the upright pose. Keep serialized capture and the Update/end-of-frame wait intact; no per-capture rebind is added. The separate workbench preview re-enables its own cloned animators so pose controls still work.
Fixes #356.
Validation
Compatibility
No public/protected symbols, parameter names, NPC IDs, save formats, or network payloads change. Native scene rigs and gameplay avatars are untouched. Explicit icons, generator selection, queue ownership, capture timing, appearance application, and spawn/finalization order are preserved. The saved-hip correction is limited to the owned fallback rig; animator re-enabling is limited to the separate workbench preview clone.