Repository navigation
get_app_folder: ignore empty or relative XDG env vars - #101
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98. An empty
XDG_*variable no longer roots the app folder at the cwd; per the XDG spec an empty or relative value is ignored and the default used.~is still expanded (backward compatible). Behavior change: a relative value is now ignored too, as the spec requires.Test added; full suite 820 passed. Dependents gate (
priv test-dependents i2 --transitive): 73 pass / 20 fail, identical set to master (environmental failures). Adversarial Opus review: approve, no blocking findings (15 env values compared old vs new; callers mood/oa/scoopy unaffected); its docstring nit was applied.🤖 Generated with Claude Code