Skip to content

get_app_folder: ignore empty or relative XDG env vars - #125

Merged
thorwhalen merged 1 commit into
masterfrom
fix/120-empty-xdg
Oct 13, 2026
Merged

thorwhalen merged 1 commit into
masterfrom
fix/120-empty-xdg

Conversation

@thorwhalen

Copy link
Copy Markdown
Member

Fixes #120. Same fix as i2mint/i2#101 and config2py#47/#53: an empty XDG_* variable no longer roots the app folder at the cwd; per the XDG spec an empty or relative value is ignored and the default used. ~ is still expanded. Behavior change: a relative value is now ignored too.

Test: dol/tests/test_app_folder.py. Suite: 660 passed.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@thorwhalen

Copy link
Copy Markdown
Member Author

Status: CI green, Opus adversarial review approved (no blocking findings). Dependents gate on this branch: 133 suites, 88 pass / 32 fail / 1 no-tests. The master baseline run timed out (exit 124, a hung suite as in thorwhalen/priv#214), so no diff is available yet. Left unmerged until a baseline comparison exists; the change is identical to the merged i2mint/i2#101.

@thorwhalen

Copy link
Copy Markdown
Member Author

Dependents gate vs master baseline (133 suites): identical except astern, which fails on master and passes on this branch (not a regression). Branch: 88 pass / 32 fail; master: 87 pass / 33 fail.

@thorwhalen
thorwhalen merged commit b2733ef into master Oct 13, 2026
12 checks passed
@thorwhalen
thorwhalen deleted the fix/120-empty-xdg branch October 13, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

util: empty env var counts as set in os.getenv(env_var, default) app-folder lookup

1 participant